From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: lrg <lrg@ti.com>, alsa-devel <alsa-devel@alsa-project.org>,
David Dajun Chen <david.chen@diasemi.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: codecs: Add DA9055 codec driver
Date: Thu, 13 Sep 2012 20:03:53 +0800 [thread overview]
Message-ID: <20120913120351.GA8374@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1347538116.16763.6.camel@matrix>
On Thu, Sep 13, 2012 at 05:38:36PM +0530, Ashish Chavan wrote:
> On Wed, 2012-09-12 at 10:57 +0800, Mark Brown wrote:
> > > + aif_ctrl |= (DA9055_AIF_OE | DA9055_AIF_EN);
> > DAPM.
> Here the trouble in making it DAPM based is that there is no separate
> control for AIF input and output. It is confirmed that AIF_EN is the
> master control bit, which enables both output as well as input. The AIF
> _OE bit is redundant. If we use the same control bit(i.e AIF_EN) for
> both DAPM_AIF_IN and DAPM_AIF_OUT, there will be obvious side effects.
> Is there any other way to take care of this? Or should we leave it
> outside DAPM?
Use a supply widget.
prev parent reply other threads:[~2012-09-13 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 15:03 [alsa-devel] [PATCH] ASoC: codecs: Add DA9055 codec driver Ashish Chavan
2012-09-12 2:57 ` Mark Brown
2012-09-12 12:56 ` Ashish Chavan
2012-09-12 12:49 ` Mark Brown
2012-09-12 13:40 ` Ashish P. Chavan
2012-09-13 12:08 ` Ashish Chavan
2012-09-13 12:03 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913120351.GA8374@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ashish.chavan@kpitcummins.com \
--cc=david.chen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox