Re: [PATCH 1/9] drivers/block/aoe/aoecmd.c: Remove useless kfree

Dan Carpenter
2012-09-13T14:42:33Z

On Thu, Sep 13, 2012 at 04:13:07PM +0200, walter harms wrote:
> > diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> > index 5461faa..cbb0521 100644
> > --- a/drivers/block/aoe/aoecmd.c
> > +++ b/drivers/block/aoe/aoecmd.c
> > @@ -1257,7 +1257,6 @@ addtgt(struct aoedev *d, char *addr, ulong nframes)
> > }
> > t = kcalloc(1, sizeof *t, GFP_ATOMIC);
> > if (!t) {
> > - kfree(t);
> > printk(KERN_INFO "aoe: cannot allocate memory to add target\n");
> > return NULL;
> > }
> >
>
>
> this should read kzalloc(sizeof (*t), GFP_ATOMIC);
> see: [PATCH 3/9] drivers/gpu/drm/ttm/ttm_page_alloc_dma.c: Remove useless kfree

I already fixed this one last week actually. I did it the way
Walter suggests.

regards,
dan carpenter