public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Robert Richter <robert.richter@amd.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] perf record: Change error message on failure
Date: Thu, 13 Sep 2012 17:07:20 +0200	[thread overview]
Message-ID: <20120913150720.GA27411@gmail.com> (raw)
In-Reply-To: <1347531654-16024-1-git-send-email-robert.richter@amd.com>


* Robert Richter <robert.richter@amd.com> wrote:

> Only report
> 
>  No CONFIG_PERF_EVENTS=y kernel support configured?
> 
> if the syscall fails with ENOSYS. In other cases CONFIG_PERF_EVENTS is
> set and might confuse users. The default message is now:
> 
>  Not all events could be opened.

Indeed, and it would be nice to be even less passive-aggressive 
and figure out and display the exact error condition?

Thanks,

	Ingo

  reply	other threads:[~2012-09-13 15:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13 10:20 [PATCH] perf record: Change error message on failure Robert Richter
2012-09-13 15:07 ` Ingo Molnar [this message]
2012-09-13 15:21   ` Robert Richter
2012-09-13 15:25     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120913150720.GA27411@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox