* [PATCH] staging: nvec: adjust for mfd_add_devices() API change
@ 2012-09-12 16:26 Stephen Warren
2012-09-12 20:07 ` Marc Dietrich
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stephen Warren @ 2012-09-12 16:26 UTC (permalink / raw)
To: Samuel Ortiz, Greg Kroah-Hartman
Cc: devel, linux-kernel, Stephen Warren, Mark Brown, Marc Dietrich
From: Stephen Warren <swarren@nvidia.com>
Commit 6607bad "mfd: core: Push irqdomain mapping out into devices"
added a new parameter to mfd_add_devices(), but missed updating the
nvec driver in staging.
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
--
Samuel, I wonder if this patch should be squashed into the commit mentioned
above in the MFD tree?
---
drivers/staging/nvec/nvec.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index b0972d0..24d8eeb 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -837,7 +837,7 @@ static int __devinit tegra_nvec_probe(struct platform_device *pdev)
}
ret = mfd_add_devices(nvec->dev, -1, nvec_devices,
- ARRAY_SIZE(nvec_devices), base, 0);
+ ARRAY_SIZE(nvec_devices), base, 0, NULL);
if (ret)
dev_err(nvec->dev, "error adding subdevices\n");
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: nvec: adjust for mfd_add_devices() API change
2012-09-12 16:26 [PATCH] staging: nvec: adjust for mfd_add_devices() API change Stephen Warren
@ 2012-09-12 20:07 ` Marc Dietrich
2012-09-14 4:46 ` Greg Kroah-Hartman
2012-09-14 7:56 ` Samuel Ortiz
2 siblings, 0 replies; 4+ messages in thread
From: Marc Dietrich @ 2012-09-12 20:07 UTC (permalink / raw)
To: Stephen Warren
Cc: Samuel Ortiz, Greg Kroah-Hartman, devel, linux-kernel,
Stephen Warren, Mark Brown
On Wednesday 12 September 2012 10:26:00 Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Commit 6607bad "mfd: core: Push irqdomain mapping out into devices"
> added a new parameter to mfd_add_devices(), but missed updating the
> nvec driver in staging.
>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Marc Dietrich <marvin24@gmx.de>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
wops, I somehow missed this one. Anyway, the patch looks fine.
Signed-off-by: Marc Dietrich <marvin24@gmx.de>
> --
> Samuel, I wonder if this patch should be squashed into the commit mentioned
> above in the MFD tree?
> ---
> drivers/staging/nvec/nvec.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index b0972d0..24d8eeb 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -837,7 +837,7 @@ static int __devinit tegra_nvec_probe(struct
> platform_device *pdev) }
>
> ret = mfd_add_devices(nvec->dev, -1, nvec_devices,
> - ARRAY_SIZE(nvec_devices), base, 0);
> + ARRAY_SIZE(nvec_devices), base, 0, NULL);
> if (ret)
> dev_err(nvec->dev, "error adding subdevices\n");
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: nvec: adjust for mfd_add_devices() API change
2012-09-12 16:26 [PATCH] staging: nvec: adjust for mfd_add_devices() API change Stephen Warren
2012-09-12 20:07 ` Marc Dietrich
@ 2012-09-14 4:46 ` Greg Kroah-Hartman
2012-09-14 7:56 ` Samuel Ortiz
2 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2012-09-14 4:46 UTC (permalink / raw)
To: Stephen Warren
Cc: Samuel Ortiz, devel, Mark Brown, Stephen Warren, linux-kernel
On Wed, Sep 12, 2012 at 10:26:00AM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Commit 6607bad "mfd: core: Push irqdomain mapping out into devices"
> added a new parameter to mfd_add_devices(), but missed updating the
> nvec driver in staging.
>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Marc Dietrich <marvin24@gmx.de>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> --
> Samuel, I wonder if this patch should be squashed into the commit mentioned
> above in the MFD tree?
Looks good to me:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: nvec: adjust for mfd_add_devices() API change
2012-09-12 16:26 [PATCH] staging: nvec: adjust for mfd_add_devices() API change Stephen Warren
2012-09-12 20:07 ` Marc Dietrich
2012-09-14 4:46 ` Greg Kroah-Hartman
@ 2012-09-14 7:56 ` Samuel Ortiz
2 siblings, 0 replies; 4+ messages in thread
From: Samuel Ortiz @ 2012-09-14 7:56 UTC (permalink / raw)
To: Stephen Warren
Cc: Greg Kroah-Hartman, devel, linux-kernel, Stephen Warren,
Mark Brown, Marc Dietrich
Hi Stephen,
On Wed, Sep 12, 2012 at 10:26:00AM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Commit 6607bad "mfd: core: Push irqdomain mapping out into devices"
> added a new parameter to mfd_add_devices(), but missed updating the
> nvec driver in staging.
>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Marc Dietrich <marvin24@gmx.de>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> --
> Samuel, I wonder if this patch should be squashed into the commit mentioned
> above in the MFD tree?
It does make sense. Squashed and pushed now, thanks for catching this one.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-14 7:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-12 16:26 [PATCH] staging: nvec: adjust for mfd_add_devices() API change Stephen Warren
2012-09-12 20:07 ` Marc Dietrich
2012-09-14 4:46 ` Greg Kroah-Hartman
2012-09-14 7:56 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox