From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Rene Buergel <rene.buergel@sohard.de>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4]: ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc
Date: Fri, 14 Sep 2012 12:04:13 +0200 [thread overview]
Message-ID: <20120914100413.GB3990@breakpoint.cc> (raw)
In-Reply-To: <6bca77b6-f91c-4ec2-acb2-91b892303502@shmail0>
On Fri, Sep 14, 2012 at 08:52:58AM +0200, Rene Buergel wrote:
> > Git should show this as a move, not as a "add a file and remove a
> > file"
> > type patch. Are you generating it properly?
>
> Whats the proper way to do this? I did a git mv, git commit and than git diff on that commit hash.
Thatis okay but while you create the patch you should use the -M switch in
`git format-patch` command. You could also try to use `git send-email` which
should create proper threads and avoid copy/paste formating problems (in case
there were any).
Sebastian
next prev parent reply other threads:[~2012-09-14 10:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <785f10f2-79bc-4708-9c57-7b505d75f223@shmail0>
2012-09-13 20:12 ` [PATCH v2 0/4]: ezusb cleanup, FX2 support, firmware downloading support Rene Buergel
2012-09-13 20:14 ` [PATCH v2 1/4]: " Rene Buergel
2012-09-13 20:15 ` [PATCH v2 2/4]: add support for Cypress FX2LP Rene Buergel
2012-09-14 5:01 ` Greg KH
2012-09-13 20:17 ` [PATCH v2 3/4]: add functions for firmware download Rene Buergel
2012-09-13 20:19 ` [PATCH v2 4/4]: ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc Rene Buergel
2012-09-14 5:03 ` Greg KH
2012-09-14 6:52 ` Rene Buergel
2012-09-14 10:04 ` Sebastian Andrzej Siewior [this message]
2012-09-14 6:55 ` Rene Buergel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914100413.GB3990@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rene.buergel@sohard.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox