public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alex Kelly <alex.page.kelly@gmail.com>,
	Andi Kleen <andi@firstfloor.org>, Cong Wang <amwang@redhat.com>,
	Denys Vlasenko <vda.linux@googlemail.com>,
	Jiri Moskovcak <jmoskovc@redhat.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH -mm] coredump-add-support-for-%d=__get_dumpable-in-core-name-fix
Date: Fri, 14 Sep 2012 14:30:34 +0200	[thread overview]
Message-ID: <20120914123034.GA28626@redhat.com> (raw)
In-Reply-To: <20120913152559.d0a9ade0.akpm@linux-foundation.org>

(fixes coredump-add-support-for-%d=__get_dumpable-in-core-name.patch)

On 09/13, Andrew Morton wrote:
>
> On Thu, 13 Sep 2012 19:28:17 +0200
> Oleg Nesterov <oleg@redhat.com> wrote:
>
> > https://bugzilla.redhat.com/show_bug.cgi?id=787135
>
> Needs a RH bugzilla account, so no Reported-by: for you!

OOPS, sorry, I didn't notice. I guess it is private by mistake..

> > This patch adds the new %d specifier for format_corename() which
> > simply reports __get_dumpable(mm->flags), this is compatible with
> > /proc/sys/fs/suid_dumpable we already have.
>
> Please prepare an update to Documentation/sysctl/kernel.txt:core_pattern?

Yes, thanks, please see below.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
 Documentation/sysctl/kernel.txt |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/Documentation/sysctl/kernel.txt b/Documentation/sysctl/kernel.txt
index 6d78841..2907ba6 100644
--- a/Documentation/sysctl/kernel.txt
+++ b/Documentation/sysctl/kernel.txt
@@ -181,6 +181,8 @@ core_pattern is used to specify a core dumpfile pattern name.
 	%p	pid
 	%u	uid
 	%g	gid
+	%d	dump mode, matches PR_SET_DUMPABLE and
+		/proc/sys/fs/suid_dumpable
 	%s	signal number
 	%t	UNIX time of dump
 	%h	hostname
-- 
1.5.5.1



  reply	other threads:[~2012-09-14 12:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13 17:28 [PATCH -mm] coredump: add support for %d=__get_dumpable() in core name Oleg Nesterov
2012-09-13 18:01 ` Neil Horman
2012-09-13 22:25 ` Andrew Morton
2012-09-14 12:30   ` Oleg Nesterov [this message]
2012-09-14 12:43   ` [PATCH] coredump: use SUID_DUMPABLE_ENABLED rather than hardcoded 1 Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120914123034.GA28626@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.page.kelly@gmail.com \
    --cc=amwang@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=jmoskovc@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox