From: Matthew Garrett <mjg59@srcf.ucam.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
David Airlie <airlied@linux.ie>
Subject: Re: [PATCH] i915: Quirk out disconnected backlight
Date: Fri, 14 Sep 2012 15:40:49 +0100 [thread overview]
Message-ID: <20120914144049.GB8195@srcf.ucam.org> (raw)
In-Reply-To: <1347632954.21322.44.camel@shinybook.infradead.org>
On Fri, Sep 14, 2012 at 03:29:14PM +0100, David Woodhouse wrote:
> On Fri, 2012-09-14 at 14:48 +0100, Matthew Garrett wrote:
> > On Fri, Sep 14, 2012 at 01:57:06PM +0100, Grant Likely wrote:
> >
> > > Tested on MacbookPro8,3. Without this patch both the intel_backlight and
> > > gmux_backlight devices get registered and userspace doesn't know which
> > > it should use.
> >
> > Userspace should be figuring out which one to use from the type field.
>
> It only does that if it's using gsd-backlight-helper to poke
> at /sys/class/backlight directly. If X exposes a backlight, (as it does
> for the Intel backlight), then gsd will just use that.
Yeah, X should be doing the same. If it's not then it's broken. OTOH, I
do agree that if we already know that we can't do anything with the
backlight (as is clearly the case if the PWM field is 0) we should just
disable it.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2012-09-14 14:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 12:57 [PATCH] i915: Quirk out disconnected backlight Grant Likely
2012-09-14 13:01 ` Chris Wilson
2012-09-14 13:09 ` Grant Likely
2012-09-14 13:12 ` David Woodhouse
2012-09-14 13:24 ` Grant Likely
2012-09-17 8:03 ` Jani Nikula
2012-09-17 16:02 ` Grant Likely
2012-09-14 13:33 ` Chris Wilson
2012-09-14 13:48 ` Matthew Garrett
2012-09-14 14:29 ` David Woodhouse
2012-09-14 14:40 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914144049.GB8195@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=dwmw2@infradead.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox