From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754584Ab2INU4D (ORCPT ); Fri, 14 Sep 2012 16:56:03 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:38765 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172Ab2INU4A (ORCPT ); Fri, 14 Sep 2012 16:56:00 -0400 Date: Fri, 14 Sep 2012 13:55:55 -0700 From: Tejun Heo To: Sasha Levin Cc: aris@redhat.com, dan.carpenter@oracle.com, fengguang.wu@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] xattr: prevent NULL ptr deref warnings in __simple_xattr_set Message-ID: <20120914205555.GT17747@google.com> References: <1347651354-16289-1-git-send-email-levinsasha928@gmail.com> <1347651354-16289-2-git-send-email-levinsasha928@gmail.com> <20120914205434.GS17747@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120914205434.GS17747@google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 14, 2012 at 01:54:34PM -0700, Tejun Heo wrote: > On Fri, Sep 14, 2012 at 09:35:54PM +0200, Sasha Levin wrote: > > Prevent warnings generated by smatch due to unchecked dereference of > > 'new_xattr' in __simple_xattr_set(). > > Isn't this an actual bug w/ or w/o smatch? Remove request (NULL > @value) w/o XATTR_REPLACE for an non-existent node would end up > calling list_add() on NULL, right? If so, please collapse these two > patches and mention the actual bug instead of smatch warning. And can somebody please make that function less confusing? - restructuring / commenting whatever. It's doing something simple. It's not supposed to be this confusing. Thanks. -- tejun