Re: [PATCH] leds: add led_trigger_rename function

[Fabio Baltieri <fabio.baltieri@gmail.com>]

Hi Kurt,

On Mon, Sep 10, 2012 at 03:55:35PM +0200, Kurt Van Dijck wrote:
> > 
> > This also implies that "name" in "struct led_trigger" is not const
> > anymore.
> IMHO, this is wrong. This forces all other led_triggers
> to put their name in non-const storage.

I had a second check on the patch and now I see your point.

> I see 2 options here:
> * let 'name' be a 'const char *', and do a typecast.
>   This works as long as led_trigger_rename is called only on led_triggers
>   with non-const 'name' storage.
> * put the storage of trigger name inside struct led_trigger conditionally
>   (like can_dev does with their echo_skb), and when calling
>   led_trigger_rename(), test if 'name' points to that storage.
> 
> Maybe there are other possibilities.

Modifying other driver would involve some useless kstrdup on constant
strigs or another unsafe casting, so I prefer to cast here in that case.

I'll send a v2 with the first solution you proposed, but I don't see a
really clean implementation here.

Any better idea?

Fabio

-- 
Fabio Baltieri