From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756420Ab2IQONk (ORCPT ); Mon, 17 Sep 2012 10:13:40 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:21845 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755516Ab2IQONi (ORCPT ); Mon, 17 Sep 2012 10:13:38 -0400 Date: Mon, 17 Sep 2012 10:02:32 -0400 From: Konrad Rzeszutek Wilk To: Sergei Shtylyov Cc: Stefano Stabellini , "arnd@arndb.de" , "xen-devel@lists.xensource.com" , "linaro-dev@lists.linaro.org" , Ian Campbell , "catalin.marinas@arm.com" , "Tim (Xen.org)" , "linux-kernel@vger.kernel.org" , "linux@arm.linux.org.uk" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 12/24] xen/arm: introduce CONFIG_XEN on ARM Message-ID: <20120917140232.GA11996@phenom.dumpdata.com> References: <1347621207-11294-12-git-send-email-stefano.stabellini@eu.citrix.com> <505374E2.5080308@mvista.com> <50571289.3040509@mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50571289.3040509@mvista.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 17, 2012 at 04:07:37PM +0400, Sergei Shtylyov wrote: > Hello. > > On 17-09-2012 14:57, Stefano Stabellini wrote: > > >>>Changes in v2: > > >>>- mark Xen guest support on ARM as EXPERIMENTAL. > > >>>Signed-off-by: Stefano Stabellini > >>>Acked-by: Konrad Rzeszutek Wilk > >>>--- > >>> arch/arm/Kconfig | 10 ++++++++++ > >>> 1 files changed, 10 insertions(+), 0 deletions(-) > > >>>diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > >>>index 2f88d8d..e92518d 100644 > >>>--- a/arch/arm/Kconfig > >>>+++ b/arch/arm/Kconfig > >>>@@ -1897,6 +1897,16 @@ config DEPRECATED_PARAM_STRUCT > >>> This was deprecated in 2001 and announced to live on for 5 years. > >>> Some old boot loaders still use this way. > >>> > >>>+config XEN_DOM0 > >>>+ def_bool y > >>>+ > >>>+config XEN > >>>+ bool "Xen guest support on ARM (EXPERIMENTAL)" > >>>+ depends on EXPERIMENTAL && ARM && OF I think the CONFIG_EXPERIMENTAL is going away. Or it has already gone away? > >>>+ select XEN_DOM0 > > >> What's the point of selecting it if it's always "y"? > > >That's because on X86 is not always "y": there are things under > >drivers/xen that compile on both platforms and depend on XEN_DOM0. > > But we're not on x86. On ARM this select is pointless. Sure, but parts of the generic Xen (drivers/xen) code functionality has checks for that (CONFIG_DOM0) to use some functionality that is not neccessarily considered "dom0" specific for ARM. The right way is to seperate those to be more of a 'backend' config and 'frontend' config. But those CONFIG options are a maze and I figured I will fix this Gordon knot once this is all accepted/compiled/works, and then slowly untangle the CONFIG-mess. > > WBR, Sergei