From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932233Ab2IQPvG (ORCPT ); Mon, 17 Sep 2012 11:51:06 -0400 Received: from wolverine01.qualcomm.com ([199.106.114.254]:27818 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932093Ab2IQPvE (ORCPT ); Mon, 17 Sep 2012 11:51:04 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6838"; a="237633913" Date: Mon, 17 Sep 2012 08:51:02 -0700 From: David Brown To: Linus Walleij Cc: Wei Yongjun , grant.likely@secretlab.ca, yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpio_msm: using for_each_set_bit to simplify the code Message-ID: <20120917155102.GA12210@codeaurora.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 17, 2012 at 12:54:45PM +0200, Linus Walleij wrote: > On Fri, Sep 14, 2012 at 4:28 AM, Wei Yongjun wrote: > > > From: Wei Yongjun > > > > Using for_each_set_bit() to simplify the code. > > > > spatch with a semantic match is used to found this. > > (http://coccinelle.lip6.fr/) > > > > Signed-off-by: Wei Yongjun > > David, does this patch look OK from your point of view? It appears to. Rohit Vaswani is doing some work on this driver, so I've also forwarded the patch to him. Acked-by: David Brown -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation