From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932500Ab2IQSWH (ORCPT ); Mon, 17 Sep 2012 14:22:07 -0400 Received: from smtprelay.restena.lu ([158.64.1.62]:53784 "EHLO smtprelay.restena.lu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932343Ab2IQSWE convert rfc822-to-8bit (ORCPT ); Mon, 17 Sep 2012 14:22:04 -0400 Date: Mon, 17 Sep 2012 20:21:08 +0200 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: Jiri Kosina Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 6/7 v2] HID: picoLCD: drop version check during probe Message-ID: <20120917202108.3e39dedb@neptune.home> In-Reply-To: <20120819185631.3a984aa4@neptune.home> References: <20120730213656.0a9f6d30@neptune.home> <20120730213859.063173c1@neptune.home> <20120819185631.3a984aa4@neptune.home> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiri, You seem not to have applied this one yet (it doesn't show up in picolcd branch). Could you please apply it? (or did I miss locking changes making it obsolete?) Thanks, Bruno On Sun, 19 August 2012 Bruno Prémont wrote: > Commit 4ea5454203d991ec85264f64f89ca8855fce69b0 > [HID: Fix race condition between driver core and ll-driver] introduced > new locking around probe/remove functions that prevents any report/reply > from hardware to reach driver until it returned from probe. > > As such, the ask-reply way to checking picoLCD firmware version during > probe is bound to timeout and let probe fail. > > Drop the check to let driver successfully probe again (until locking issues > are resolved allowing to reinstate the check). > > Signed-off-by: Bruno Prémont > --- > > Changes since v1: > - drop version check during probe instead of commenting it out. > > > drivers/hid/hid-picolcd_core.c | 18 ------------------ > 1 files changed, 0 insertions(+), 18 deletions(-)