* Taint kernel when we detect a corrupted slab. @ 2012-09-18 15:05 Dave Jones 2012-09-18 16:57 ` Christoph Lameter 0 siblings, 1 reply; 6+ messages in thread From: Dave Jones @ 2012-09-18 15:05 UTC (permalink / raw) To: Linux Kernel; +Cc: cl It doesn't seem worth adding a new taint flag for this, so just re-use the one from 'bad page' Signed-off-by: Dave Jones <davej@redhat.com> diff --git a/mm/slub.c b/mm/slub.c index 2fdd96f..0c5009d 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -568,6 +568,8 @@ static void slab_bug(struct kmem_cache *s, char *fmt, ...) printk(KERN_ERR "BUG %s (%s): %s\n", s->name, print_tainted(), buf); printk(KERN_ERR "----------------------------------------" "-------------------------------------\n\n"); + + add_taint(TAINT_BAD_PAGE); } static void slab_fix(struct kmem_cache *s, char *fmt, ...) ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: Taint kernel when we detect a corrupted slab. 2012-09-18 15:05 Taint kernel when we detect a corrupted slab Dave Jones @ 2012-09-18 16:57 ` Christoph Lameter 2012-09-18 19:27 ` David Rientjes 0 siblings, 1 reply; 6+ messages in thread From: Christoph Lameter @ 2012-09-18 16:57 UTC (permalink / raw) To: Dave Jones; +Cc: Linux Kernel, Pekka Enberg On Tue, 18 Sep 2012, Dave Jones wrote: > It doesn't seem worth adding a new taint flag for this, so just re-use > the one from 'bad page' Acked-by: Christoph Lameter <cl@linux.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Taint kernel when we detect a corrupted slab. 2012-09-18 16:57 ` Christoph Lameter @ 2012-09-18 19:27 ` David Rientjes 2012-09-18 19:54 ` Dave Jones 0 siblings, 1 reply; 6+ messages in thread From: David Rientjes @ 2012-09-18 19:27 UTC (permalink / raw) To: Christoph Lameter; +Cc: Dave Jones, Linux Kernel, Pekka Enberg On Tue, 18 Sep 2012, Christoph Lameter wrote: > On Tue, 18 Sep 2012, Dave Jones wrote: > > > It doesn't seem worth adding a new taint flag for this, so just re-use > > the one from 'bad page' > > Acked-by: Christoph Lameter <cl@linux.com> [Fixing Pekka's email address] Dave, would you like to add something similar to __slab_error() for CONFIG_SLAB? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Taint kernel when we detect a corrupted slab. 2012-09-18 19:27 ` David Rientjes @ 2012-09-18 19:54 ` Dave Jones 2012-09-18 20:19 ` David Rientjes 0 siblings, 1 reply; 6+ messages in thread From: Dave Jones @ 2012-09-18 19:54 UTC (permalink / raw) To: David Rientjes; +Cc: Christoph Lameter, Linux Kernel, Pekka Enberg On Tue, Sep 18, 2012 at 12:27:58PM -0700, David Rientjes wrote: > On Tue, 18 Sep 2012, Christoph Lameter wrote: > > > On Tue, 18 Sep 2012, Dave Jones wrote: > > > > > It doesn't seem worth adding a new taint flag for this, so just re-use > > > the one from 'bad page' > > > > Acked-by: Christoph Lameter <cl@linux.com> > > [Fixing Pekka's email address] > > Dave, would you like to add something similar to __slab_error() for > CONFIG_SLAB? Sure. This ? Dave -- Taint kernel when we detect a corrupted slab. It doesn't seem worth adding a new taint flag for this, so just re-use the one from 'bad page' Signed-off-by: Dave Jones <davej@redhat.com> diff --git a/mm/slub.c b/mm/slub.c index 2fdd96f..0c5009d 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -568,6 +568,8 @@ static void slab_bug(struct kmem_cache *s, char *fmt, ...) printk(KERN_ERR "BUG %s (%s): %s\n", s->name, print_tainted(), buf); printk(KERN_ERR "----------------------------------------" "-------------------------------------\n\n"); + + add_taint(TAINT_BAD_PAGE); } static void slab_fix(struct kmem_cache *s, char *fmt, ...) diff --git a/mm/slab.c b/mm/slab.c index c685475..cbce8c9 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -818,6 +818,7 @@ static void __slab_error(const char *function, struct kmem_cache *cachep, printk(KERN_ERR "slab error in %s(): cache `%s': %s\n", function, cachep->name, msg); dump_stack(); + add_taint(TAINT_BAD_PAGE); } /* ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: Taint kernel when we detect a corrupted slab. 2012-09-18 19:54 ` Dave Jones @ 2012-09-18 20:19 ` David Rientjes 2012-09-19 7:09 ` Pekka Enberg 0 siblings, 1 reply; 6+ messages in thread From: David Rientjes @ 2012-09-18 20:19 UTC (permalink / raw) To: Dave Jones, Christoph Lameter, Linux Kernel, Pekka Enberg On Tue, 18 Sep 2012, Dave Jones wrote: > It doesn't seem worth adding a new taint flag for this, so just re-use > the one from 'bad page' > > Signed-off-by: Dave Jones <davej@redhat.com> Acked-by: David Rientjes <rientjes@google.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Taint kernel when we detect a corrupted slab. 2012-09-18 20:19 ` David Rientjes @ 2012-09-19 7:09 ` Pekka Enberg 0 siblings, 0 replies; 6+ messages in thread From: Pekka Enberg @ 2012-09-19 7:09 UTC (permalink / raw) To: David Rientjes; +Cc: Dave Jones, Christoph Lameter, Linux Kernel, Andrew Morton On Tue, 18 Sep 2012, Dave Jones wrote: >> It doesn't seem worth adding a new taint flag for this, so just re-use >> the one from 'bad page' >> >> Signed-off-by: Dave Jones <davej@redhat.com> On Tue, Sep 18, 2012 at 11:19 PM, David Rientjes <rientjes@google.com> wrote: > Acked-by: David Rientjes <rientjes@google.com> Applied, thanks! ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-19 7:09 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-09-18 15:05 Taint kernel when we detect a corrupted slab Dave Jones 2012-09-18 16:57 ` Christoph Lameter 2012-09-18 19:27 ` David Rientjes 2012-09-18 19:54 ` Dave Jones 2012-09-18 20:19 ` David Rientjes 2012-09-19 7:09 ` Pekka Enberg
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox