From: Oleg Nesterov <oleg@redhat.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: Denys Vlasenko <vda.linux@googlemail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Amerigo Wang <amwang@redhat.com>,
"Jonathan M. Foote" <jmfoote@cert.org>,
Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH -mm v2] coredump: extend core dump note section to contain file names of mapped files
Date: Tue, 18 Sep 2012 19:36:05 +0200 [thread overview]
Message-ID: <20120918173605.GA27653@redhat.com> (raw)
In-Reply-To: <20120918172720.GA26606@redhat.com>
On 09/18, Oleg Nesterov wrote:
>
> On 09/18, Roland McGrath wrote:
> >
> > It's doubtful that rolling your own single loop actually performs better
> > than just calling strlen and memcpy.
Ah, I misread your message, sorry...
> This is needed to advance 'name' if d_path() fails with !ENAMETOOLONG.
> Probably needs a comment.
>
> Or perhaps 'filename = ""' case can handle this case itself. In this
> case we do not even need strlen(), remaining = name - filename.
Yes, but you strlen + memcpy as you suggested will work too.
Oleg.
next prev parent reply other threads:[~2012-09-18 17:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 14:55 [PATCH -mm v2] coredump: extend core dump note section to contain file names of mapped files Denys Vlasenko
2012-09-18 15:36 ` Oleg Nesterov
2012-09-18 16:47 ` Jonathan M. Foote
2012-09-18 16:58 ` Roland McGrath
2012-09-18 17:27 ` Oleg Nesterov
2012-09-18 17:36 ` Oleg Nesterov [this message]
2012-09-18 17:47 ` Oleg Nesterov
2012-09-19 11:50 ` Oleg Nesterov
2012-09-19 16:16 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120918173605.GA27653@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=jmfoote@cert.org \
--cc=linux-kernel@vger.kernel.org \
--cc=palves@redhat.com \
--cc=roland@hack.frob.com \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox