From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752557Ab2ISBa5 (ORCPT ); Tue, 18 Sep 2012 21:30:57 -0400 Received: from mga11.intel.com ([192.55.52.93]:59677 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752044Ab2ISBa4 (ORCPT ); Tue, 18 Sep 2012 21:30:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,446,1344236400"; d="scan'208";a="223755081" Date: Wed, 19 Sep 2012 09:30:51 +0800 From: Fengguang Wu To: Samuel Ortiz Cc: Haojian Zhuang , LKML Subject: [PATCH] mfd: use IRQF_ONESHOT for 88pm860x Message-ID: <20120919013051.GA14171@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT. Signed-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! drivers/mfd/88pm860x-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux.orig/drivers/mfd/88pm860x-core.c 2012-09-18 08:22:36.377180459 +0800 +++ linux/drivers/mfd/88pm860x-core.c 2012-09-19 09:27:14.335969275 +0800 @@ -498,7 +498,7 @@ static int __devinit device_irq_init(str #endif } - ret = request_threaded_irq(chip->core_irq, NULL, pm860x_irq, flags, + ret = request_threaded_irq(chip->core_irq, NULL, pm860x_irq, flags | IRQF_ONESHOT, "88pm860x", chip); if (ret) { dev_err(chip->dev, "Failed to request IRQ: %d\n", ret);