From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752819Ab2ISBco (ORCPT ); Tue, 18 Sep 2012 21:32:44 -0400 Received: from mga11.intel.com ([192.55.52.93]:55761 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752207Ab2ISBcn (ORCPT ); Tue, 18 Sep 2012 21:32:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,446,1344236400"; d="scan'208";a="223755589" Date: Wed, 19 Sep 2012 09:32:38 +0800 From: Fengguang Wu To: Samuel Ortiz Cc: Peter Ujfalusi , LKML Subject: [PATCH] mfd: use IRQF_ONESHOT for twl6040 Message-ID: <20120919013238.GA14408@localhost> References: <20120919013051.GA14171@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120919013051.GA14171@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT. Signed-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! drivers/mfd/twl6040-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux.orig/drivers/mfd/twl6040-core.c 2012-09-18 08:22:36.381180459 +0800 +++ linux/drivers/mfd/twl6040-core.c 2012-09-19 09:27:15.947969313 +0800 @@ -584,7 +584,7 @@ static int __devinit twl6040_probe(struc goto irq_init_err; ret = request_threaded_irq(twl6040->irq_base + TWL6040_IRQ_READY, - NULL, twl6040_naudint_handler, 0, + NULL, twl6040_naudint_handler, IRQF_ONESHOT, "twl6040_irq_ready", twl6040); if (ret) { dev_err(twl6040->dev, "READY IRQ request failed: %d\n",