From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753427Ab2ISBhj (ORCPT ); Tue, 18 Sep 2012 21:37:39 -0400 Received: from mga11.intel.com ([192.55.52.93]:9851 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752808Ab2ISBhi (ORCPT ); Tue, 18 Sep 2012 21:37:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,446,1344236400"; d="scan'208";a="223757004" Date: Wed, 19 Sep 2012 09:37:32 +0800 From: Fengguang Wu To: Greg Kroah-Hartman Cc: Rupesh Gujare , Chris Kelly , devel@driverdev.osuosl.org, LKML Subject: [PATCH] staging: ozwpan: compare pointer to NULL rather than 0 Message-ID: <20120919013732.GA15367@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Generated by: scripts/coccinelle/null/badzero.cocci Signed-off-by: Fengguang Wu --- drivers/staging/ozwpan/ozcdev.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) --- linux.orig/drivers/staging/ozwpan/ozcdev.c 2012-09-19 09:33:20.887977986 +0800 +++ linux/drivers/staging/ozwpan/ozcdev.c 2012-09-19 09:33:32.383978265 +0800 @@ -104,10 +104,10 @@ ssize_t oz_cdev_read(struct file *filp, if (pd) oz_pd_get(pd); spin_unlock_bh(&g_cdev.lock); - if (pd == 0) + if (pd == NULL) return -1; ctx = oz_cdev_claim_ctx(pd); - if (ctx == 0) + if (ctx == NULL) goto out2; n = ctx->rd_in - ctx->rd_out; if (n < 0) @@ -157,11 +157,11 @@ ssize_t oz_cdev_write(struct file *filp, if (pd) oz_pd_get(pd); spin_unlock_bh(&g_cdev.lock); - if (pd == 0) + if (pd == NULL) return -1; eb = &pd->elt_buff; ei = oz_elt_info_alloc(eb); - if (ei == 0) { + if (ei == NULL) { count = 0; goto out; } @@ -410,7 +410,7 @@ int oz_cdev_start(struct oz_pd *pd, int return 0; } ctx = kzalloc(sizeof(struct oz_serial_ctx), GFP_ATOMIC); - if (ctx == 0) + if (ctx == NULL) return -ENOMEM; atomic_set(&ctx->ref_count, 1); ctx->tx_seq_num = 1; @@ -424,7 +424,7 @@ int oz_cdev_start(struct oz_pd *pd, int spin_unlock_bh(&pd->app_lock[OZ_APPID_SERIAL-1]); } spin_lock(&g_cdev.lock); - if ((g_cdev.active_pd == 0) && + if ((g_cdev.active_pd == NULL) && (memcmp(pd->mac_addr, g_cdev.active_addr, ETH_ALEN) == 0)) { oz_pd_get(pd); g_cdev.active_pd = pd; @@ -477,7 +477,7 @@ void oz_cdev_rx(struct oz_pd *pd, struct int ix; ctx = oz_cdev_claim_ctx(pd); - if (ctx == 0) { + if (ctx == NULL) { oz_trace("Cannot claim serial context.\n"); return; }