From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753108Ab2ISBls (ORCPT ); Tue, 18 Sep 2012 21:41:48 -0400 Received: from mga11.intel.com ([192.55.52.93]:43049 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752449Ab2ISBlo (ORCPT ); Tue, 18 Sep 2012 21:41:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,446,1344236400"; d="scan'208";a="223758237" Date: Wed, 19 Sep 2012 09:41:13 +0800 From: Fengguang Wu To: Samuel Ortiz Cc: Haojian Zhuang , LKML Subject: [PATCH] mfd: use IRQF_ONESHOT for max8925 Message-ID: <20120919014113.GA15981@localhost> References: <20120919013051.GA14171@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120919013051.GA14171@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT. Signed-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! drivers/mfd/max8925-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux.orig/drivers/mfd/max8925-core.c 2012-09-18 08:22:36.381180459 +0800 +++ linux/drivers/mfd/max8925-core.c 2012-09-19 09:37:52.471984440 +0800 @@ -547,7 +547,7 @@ static int max8925_irq_init(struct max89 goto tsc_irq; } - ret = request_threaded_irq(irq, NULL, max8925_irq, flags, + ret = request_threaded_irq(irq, NULL, max8925_irq, flags | IRQF_ONESHOT, "max8925", chip); if (ret) { dev_err(chip->dev, "Failed to request core IRQ: %d\n", ret); @@ -565,7 +565,7 @@ tsc_irq: chip->tsc_irq = pdata->tsc_irq; ret = request_threaded_irq(chip->tsc_irq, NULL, max8925_tsc_irq, - flags, "max8925-tsc", chip); + flags | IRQF_ONESHOT, "max8925-tsc", chip); if (ret) { dev_err(chip->dev, "Failed to request TSC IRQ: %d\n", ret); chip->tsc_irq = 0;