From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] workqueue: Keep activate-order equals to queue_work()-order
Date: Wed, 19 Sep 2012 10:42:13 -0700 [thread overview]
Message-ID: <20120919174213.GK8474@google.com> (raw)
In-Reply-To: <50599AC4.303@cn.fujitsu.com>
Hello, Lai.
On Wed, Sep 19, 2012 at 06:13:24PM +0800, Lai Jiangshan wrote:
> From 314d43f087c85b11a29be0555f32deeb742bf18e Mon Sep 17 00:00:00 2001
> From: Lai Jiangshan <laijs@cn.fujitsu.com>
> Date: Tue, 18 Sep 2012 16:26:30 +0800
> Subject: [PATCH] workqueue: use common cwq_set_max_active() for
> workqueue_set_max_active()
>
> workqueue_set_max_active() may increase ->max_active without activating
> delayed works. And it may cause the activation order doesn't equal to
> to queue_work()-order.
>
> To make things consist, we use common cwq_set_max_active() logic which
> immediately makes use of the newly increased max_mactive if there are
> delayed work items and also keep activation ordering.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Applied 1-2 to wq/for-3.7 with minor updates to comments and
descriptions.
Thanks for doing this!
--
tejun
next prev parent reply other threads:[~2012-09-19 17:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 8:36 [PATCH 1/2] workqueue: intruduce cwq_set_max_active() helper for thaw_workqueues() Lai Jiangshan
2012-09-18 8:36 ` [PATCH 2/2] workqueue: Keep activate-order equals to queue_work()-order Lai Jiangshan
2012-09-18 17:05 ` Tejun Heo
2012-09-18 17:08 ` Tejun Heo
2012-09-19 10:13 ` Lai Jiangshan
2012-09-19 17:42 ` Tejun Heo [this message]
2012-09-19 9:57 ` Lai Jiangshan
2012-09-19 17:31 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919174213.GK8474@google.com \
--to=tj@kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox