* [PATCH] mfd: use IRQF_ONESHOT for twl6040
2012-09-19 1:30 [PATCH] mfd: use IRQF_ONESHOT for 88pm860x Fengguang Wu
@ 2012-09-19 1:32 ` Fengguang Wu
2012-09-19 6:19 ` Peter Ujfalusi
2012-09-19 1:41 ` [PATCH] mfd: use IRQF_ONESHOT for max8925 Fengguang Wu
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Fengguang Wu @ 2012-09-19 1:32 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: Peter Ujfalusi, LKML
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Make sure threaded IRQs without a primary handler are always request
with IRQF_ONESHOT.
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
Please take the patch only if it's a positive warning. Thanks!
drivers/mfd/twl6040-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux.orig/drivers/mfd/twl6040-core.c 2012-09-18 08:22:36.381180459 +0800
+++ linux/drivers/mfd/twl6040-core.c 2012-09-19 09:27:15.947969313 +0800
@@ -584,7 +584,7 @@ static int __devinit twl6040_probe(struc
goto irq_init_err;
ret = request_threaded_irq(twl6040->irq_base + TWL6040_IRQ_READY,
- NULL, twl6040_naudint_handler, 0,
+ NULL, twl6040_naudint_handler, IRQF_ONESHOT,
"twl6040_irq_ready", twl6040);
if (ret) {
dev_err(twl6040->dev, "READY IRQ request failed: %d\n",
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] mfd: use IRQF_ONESHOT for twl6040
2012-09-19 1:32 ` [PATCH] mfd: use IRQF_ONESHOT for twl6040 Fengguang Wu
@ 2012-09-19 6:19 ` Peter Ujfalusi
0 siblings, 0 replies; 7+ messages in thread
From: Peter Ujfalusi @ 2012-09-19 6:19 UTC (permalink / raw)
To: Fengguang Wu; +Cc: Samuel Ortiz, LKML
On 09/19/2012 04:32 AM, Fengguang Wu wrote:
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
>
> Make sure threaded IRQs without a primary handler are always request
> with IRQF_ONESHOT.
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>
> Please take the patch only if it's a positive warning. Thanks!
>
> drivers/mfd/twl6040-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux.orig/drivers/mfd/twl6040-core.c 2012-09-18 08:22:36.381180459 +0800
> +++ linux/drivers/mfd/twl6040-core.c 2012-09-19 09:27:15.947969313 +0800
> @@ -584,7 +584,7 @@ static int __devinit twl6040_probe(struc
> goto irq_init_err;
>
> ret = request_threaded_irq(twl6040->irq_base + TWL6040_IRQ_READY,
> - NULL, twl6040_naudint_handler, 0,
> + NULL, twl6040_naudint_handler, IRQF_ONESHOT,
> "twl6040_irq_ready", twl6040);
> if (ret) {
> dev_err(twl6040->dev, "READY IRQ request failed: %d\n",
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] mfd: use IRQF_ONESHOT for max8925
2012-09-19 1:30 [PATCH] mfd: use IRQF_ONESHOT for 88pm860x Fengguang Wu
2012-09-19 1:32 ` [PATCH] mfd: use IRQF_ONESHOT for twl6040 Fengguang Wu
@ 2012-09-19 1:41 ` Fengguang Wu
2012-09-19 11:26 ` [PATCH] mfd: use IRQF_ONESHOT for 88pm860x Samuel Ortiz
2012-09-19 23:24 ` [PATCH] mfd: arizona: use IRQF_ONESHOT Fengguang Wu
3 siblings, 0 replies; 7+ messages in thread
From: Fengguang Wu @ 2012-09-19 1:41 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: Haojian Zhuang, LKML
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Make sure threaded IRQs without a primary handler are always request
with IRQF_ONESHOT.
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
Please take the patch only if it's a positive warning. Thanks!
drivers/mfd/max8925-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux.orig/drivers/mfd/max8925-core.c 2012-09-18 08:22:36.381180459 +0800
+++ linux/drivers/mfd/max8925-core.c 2012-09-19 09:37:52.471984440 +0800
@@ -547,7 +547,7 @@ static int max8925_irq_init(struct max89
goto tsc_irq;
}
- ret = request_threaded_irq(irq, NULL, max8925_irq, flags,
+ ret = request_threaded_irq(irq, NULL, max8925_irq, flags | IRQF_ONESHOT,
"max8925", chip);
if (ret) {
dev_err(chip->dev, "Failed to request core IRQ: %d\n", ret);
@@ -565,7 +565,7 @@ tsc_irq:
chip->tsc_irq = pdata->tsc_irq;
ret = request_threaded_irq(chip->tsc_irq, NULL, max8925_tsc_irq,
- flags, "max8925-tsc", chip);
+ flags | IRQF_ONESHOT, "max8925-tsc", chip);
if (ret) {
dev_err(chip->dev, "Failed to request TSC IRQ: %d\n", ret);
chip->tsc_irq = 0;
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] mfd: use IRQF_ONESHOT for 88pm860x
2012-09-19 1:30 [PATCH] mfd: use IRQF_ONESHOT for 88pm860x Fengguang Wu
2012-09-19 1:32 ` [PATCH] mfd: use IRQF_ONESHOT for twl6040 Fengguang Wu
2012-09-19 1:41 ` [PATCH] mfd: use IRQF_ONESHOT for max8925 Fengguang Wu
@ 2012-09-19 11:26 ` Samuel Ortiz
2012-09-19 23:24 ` [PATCH] mfd: arizona: use IRQF_ONESHOT Fengguang Wu
3 siblings, 0 replies; 7+ messages in thread
From: Samuel Ortiz @ 2012-09-19 11:26 UTC (permalink / raw)
To: Fengguang Wu; +Cc: Haojian Zhuang, LKML
Hi Fengguang,
On Wed, Sep 19, 2012 at 09:30:51AM +0800, Fengguang Wu wrote:
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
>
> Make sure threaded IRQs without a primary handler are always request
> with IRQF_ONESHOT.
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
All 3 patches applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] mfd: arizona: use IRQF_ONESHOT
2012-09-19 1:30 [PATCH] mfd: use IRQF_ONESHOT for 88pm860x Fengguang Wu
` (2 preceding siblings ...)
2012-09-19 11:26 ` [PATCH] mfd: use IRQF_ONESHOT for 88pm860x Samuel Ortiz
@ 2012-09-19 23:24 ` Fengguang Wu
2012-09-20 0:41 ` Mark Brown
3 siblings, 1 reply; 7+ messages in thread
From: Fengguang Wu @ 2012-09-19 23:24 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: Mark Brown, LKML
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Make sure threaded IRQs without a primary handler are always request
with IRQF_ONESHOT.
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
Please take the patch only if it's a positive warning. Thanks!
drivers/mfd/arizona-irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux.orig/drivers/mfd/arizona-irq.c 2012-08-03 15:36:21.583560783 +0800
+++ linux/drivers/mfd/arizona-irq.c 2012-09-20 07:21:10.932045625 +0800
@@ -236,7 +236,7 @@ int arizona_irq_init(struct arizona *ari
}
ret = request_threaded_irq(arizona->irq, NULL, arizona_irq_thread,
- flags, "arizona", arizona);
+ flags | IRQF_ONESHOT, "arizona", arizona);
if (ret != 0) {
dev_err(arizona->dev, "Failed to request IRQ %d: %d\n",
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] mfd: arizona: use IRQF_ONESHOT
2012-09-19 23:24 ` [PATCH] mfd: arizona: use IRQF_ONESHOT Fengguang Wu
@ 2012-09-20 0:41 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2012-09-20 0:41 UTC (permalink / raw)
To: Fengguang Wu; +Cc: Samuel Ortiz, LKML
On Thu, Sep 20, 2012 at 07:24:03AM +0800, Fengguang Wu wrote:
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
>
> Make sure threaded IRQs without a primary handler are always request
> with IRQF_ONESHOT.
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>
> Please take the patch only if it's a positive warning. Thanks!
It's a false positive - these interrupts can only be generated by a
threaded interrupt controller.
^ permalink raw reply [flat|nested] 7+ messages in thread