From: Arnd Bergmann <arnd@arndb.de>
To: Jonathan Corbet <corbet@lwn.net>
Cc: "Allen Huang" <allen_huang@davicom.com.tw>,
linux-kernel@vger.kernel.org,
"'Michael Chen'" <michael_chen@mail.davicom.com.tw>,
'Charles' <charles_tsai@davicom.com.tw>,
"'Joseph Chang'" <joseph_chang@mail.davicom.com.tw>
Subject: Re: Davicom DM9000C driver
Date: Thu, 20 Sep 2012 09:08:00 +0000 [thread overview]
Message-ID: <201209200908.00519.arnd@arndb.de> (raw)
In-Reply-To: <20120919173524.7bf4a974@lwn.net>
On Wednesday 19 September 2012, Jonathan Corbet wrote:
> On Wed, 19 Sep 2012 13:58:08 +0800
> Allen Huang (黃偉格) <allen_huang@davicom.com.tw> wrote:
>
> > I'm Allen Huang from Davicom. We are hereby opensourcing the linux
> > driver for our DM9000C.
>
> That is great, but please read the development process documentation on
> how best to submit something like this. We would much rather see a patch
> (inline, not as an attachment) to facilitate the review.
More importantly, the patch should be against the version that is
already present in the kernel as drivers/net/ethernet/davicom/dm9000.c,
which appears to be mostly the same as the version that is submitted
here.
So while all the comments on the driver are valuable, they also apply
to the code we already have since 2005.
Arnd
next prev parent reply other threads:[~2012-09-20 9:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 5:58 Davicom DM9000C driver Allen Huang (黃偉格)
2012-09-19 16:39 ` Bruno Prémont
2012-09-19 23:35 ` Jonathan Corbet
2012-09-20 9:08 ` Arnd Bergmann [this message]
2012-09-20 11:02 ` Arnd Bergmann
2012-09-21 1:49 ` Michael Chen
2012-09-20 13:30 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209200908.00519.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=allen_huang@davicom.com.tw \
--cc=charles_tsai@davicom.com.tw \
--cc=corbet@lwn.net \
--cc=joseph_chang@mail.davicom.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=michael_chen@mail.davicom.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox