From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756526Ab2ITX4t (ORCPT ); Thu, 20 Sep 2012 19:56:49 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:44506 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754863Ab2ITX4r (ORCPT ); Thu, 20 Sep 2012 19:56:47 -0400 Date: Thu, 20 Sep 2012 16:56:43 -0700 From: Tejun Heo To: Kent Overstreet Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, axboe@kernel.dk, neilb@suse.de Subject: Re: [PATCH v2 10/26] block: Add submit_bio_wait(), remove from md Message-ID: <20120920235643.GQ7264@google.com> References: <1347322957-25260-1-git-send-email-koverstreet@google.com> <1347322957-25260-11-git-send-email-koverstreet@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1347322957-25260-11-git-send-email-koverstreet@google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 10, 2012 at 05:22:21PM -0700, Kent Overstreet wrote: > Random cleanup - this code was duplicated and it's not really specific > to md. > > Also added the ability to return the actual error code. > > Signed-off-by: Kent Overstreet > CC: Jens Axboe > CC: NeilBrown Acked-by: Tejun Heo > --- a/include/linux/bio.h > +++ b/include/linux/bio.h > @@ -249,6 +249,7 @@ extern void bio_endio(struct bio *, int); > struct request_queue; > extern int bio_phys_segments(struct request_queue *, struct bio *); > > +extern int submit_bio_wait(int rw, struct bio *bio); > void bio_advance(struct bio *, unsigned); Heh, this is one of the reasons why I don't like extern on function prototypes. It's not necessary and people end up jumping between the two forms. :( Thanks. -- tejun