From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756568Ab2IUAFB (ORCPT ); Thu, 20 Sep 2012 20:05:01 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:62081 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756500Ab2IUAFA (ORCPT ); Thu, 20 Sep 2012 20:05:00 -0400 Date: Thu, 20 Sep 2012 17:04:57 -0700 From: Kent Overstreet To: Tejun Heo Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, axboe@kernel.dk, neilb@suse.de Subject: Re: [PATCH v2 08/26] block: Remove bi_idx references Message-ID: <20120921000456.GI5519@google.com> References: <1347322957-25260-1-git-send-email-koverstreet@google.com> <1347322957-25260-9-git-send-email-koverstreet@google.com> <20120920234953.GO7264@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120920234953.GO7264@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 20, 2012 at 04:49:53PM -0700, Tejun Heo wrote: > On Mon, Sep 10, 2012 at 05:22:19PM -0700, Kent Overstreet wrote: > > These were harmless but uneccessary,andt getting rid of them makes the > > code easier to audit since most of them need to be removed. > > I find the descriptions a bit too terse. Why do they need to be > removed? So, I suppose you wanted to say explicit initializations to > 0 are unnecessary, but there are bio_segments() conversions too. > > The patch is simple and this isn't a big deal but I really hope for > better (correct) descriptions. It's because for the bvec iterator stuff and immutable bvecs, direct bi_idx usage tends to be either wrong or unnecessary - I had to audit all the uses in the kernel. Reason for doing it now is a later patch moves bi_idx (also bi_sector and bi_size) into a different struct - so doing these cleanup patches first means a bit less code churn.