From: Richard Davies <richard@arachsys.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Shaohua Li <shli@kernel.org>, Rik van Riel <riel@redhat.com>,
Avi Kivity <avi@redhat.com>, QEMU-devel <qemu-devel@nongnu.org>,
KVM <kvm@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/6] Reduce compaction scanning and lock contention
Date: Fri, 21 Sep 2012 10:49:34 +0100 [thread overview]
Message-ID: <20120921094934.GB1928@alpha.arachsys.com> (raw)
In-Reply-To: <20120921093530.GS11266@suse.de>
Mel Gorman wrote:
> > I did manage to get a couple which were slightly worse, but nothing like as
> > bad as before. Here are the results:
> >
> > # grep -F '[k]' report | head -8
> > 45.60% qemu-kvm [kernel.kallsyms] [k] clear_page_c
> > 11.26% qemu-kvm [kernel.kallsyms] [k] isolate_freepages_block
> > 3.21% qemu-kvm [kernel.kallsyms] [k] _raw_spin_lock
> > 2.27% ksmd [kernel.kallsyms] [k] memcmp
> > 2.02% swapper [kernel.kallsyms] [k] default_idle
> > 1.58% qemu-kvm [kernel.kallsyms] [k] svm_vcpu_run
> > 1.30% qemu-kvm [kernel.kallsyms] [k] _raw_spin_lock_irqsave
> > 1.09% qemu-kvm [kernel.kallsyms] [k] get_page_from_freelist
> >
> > # grep -F '[k]' report | head -8
> > 61.29% qemu-kvm [kernel.kallsyms] [k] clear_page_c
> > 4.52% qemu-kvm [kernel.kallsyms] [k] _raw_spin_lock_irqsave
> > 2.64% qemu-kvm [kernel.kallsyms] [k] copy_page_c
> > 1.61% swapper [kernel.kallsyms] [k] default_idle
> > 1.57% qemu-kvm [kernel.kallsyms] [k] _raw_spin_lock
> > 1.18% qemu-kvm [kernel.kallsyms] [k] get_page_from_freelist
> > 1.18% qemu-kvm [kernel.kallsyms] [k] isolate_freepages_block
> > 1.11% qemu-kvm [kernel.kallsyms] [k] svm_vcpu_run
>
> Were the boot times acceptable even when these slightly worse figures
> were recorded?
Yes, they were 10-20% slower as you might expect from the traces, rather
than a factor slower.
> Thank you for the detailed reporting and the testing, it's much
> appreciated. I've already rebased the patches to Andrew's tree and tested
> them overnight and the figures look good on my side. I'll update the
> changelog and push them shortly.
Great. On my side, I'm delighted that senior kernel developers such as you,
Rik and Avi took our bug report seriously and helped fix it!
Thank you,
Richard.
prev parent reply other threads:[~2012-09-21 9:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 14:04 [PATCH 0/6] Reduce compaction scanning and lock contention Mel Gorman
2012-09-20 14:04 ` [PATCH 1/6] mm: compaction: Abort compaction loop if lock is contended or run too long Mel Gorman
2012-09-20 18:53 ` Rik van Riel
2012-09-20 14:04 ` [PATCH 2/6] mm: compaction: Acquire the zone->lru_lock as late as possible Mel Gorman
2012-09-20 18:54 ` Rik van Riel
2012-09-20 14:04 ` [PATCH 3/6] mm: compaction: Acquire the zone->lock " Mel Gorman
2012-09-20 18:54 ` Rik van Riel
2012-09-20 14:04 ` [PATCH 4/6] Revert "mm: have order > 0 compaction start off where it left" Mel Gorman
2012-09-20 18:54 ` Rik van Riel
2012-09-20 14:04 ` [PATCH 5/6] mm: compaction: Cache if a pageblock was scanned and no pages were isolated Mel Gorman
2012-09-20 18:55 ` Rik van Riel
2012-09-20 14:04 ` [PATCH 6/6] mm: compaction: Restart compaction from near where it left off Mel Gorman
2012-09-20 18:57 ` Rik van Riel
2012-09-21 9:13 ` [PATCH 0/6] Reduce compaction scanning and lock contention Richard Davies
2012-09-21 9:15 ` Richard Davies
2012-09-21 9:17 ` Richard Davies
2012-09-21 9:55 ` Mel Gorman
2012-09-21 9:18 ` Richard Davies
2012-09-21 9:35 ` Mel Gorman
2012-09-21 9:49 ` Richard Davies [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921094934.GB1928@alpha.arachsys.com \
--to=richard@arachsys.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox