From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Jan Beulich <JBeulich@suse.com>,
Oliver Chick <oliver.chick@citrix.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [Xen-devel] [PATCH] Persistent grant maps for xen blk drivers
Date: Fri, 21 Sep 2012 10:27:33 -0400 [thread overview]
Message-ID: <20120921142733.GB3389@phenom.dumpdata.com> (raw)
In-Reply-To: <505C5C54.4060100@citrix.com>
On Fri, Sep 21, 2012 at 01:23:48PM +0100, David Vrabel wrote:
> On 20/09/12 12:48, Jan Beulich wrote:
> >>>> On 20.09.12 at 13:30, Oliver Chick <oliver.chick@citrix.com> wrote:
> >> The memory overhead, and fallback mode points are related:
> >> -Firstly, it turns out that the overhead is actually 2.75MB, not 11MB
> >> per device. I made a mistake (pointed out by Jan) as the maximum number
> >> of requests that can fit into a single-page ring is 64, not 256.
> >> -Clearly, this still scales linearly. So the problem of memory footprint
> >> will occur with more VMs, or block devices.
> >> -Whilst 2.75MB per device is probably acceptable (?), if we start using
> >> multipage rings, then we might not want to have
> >> BLKIF_MAX_PERS_REQUESTS_PER_DEVICE==__RING_SIZE, as this will cause the
> >> memory overhead to increase. This is why I have implemented the
> >> 'fallback' mode. With a multipage ring, it seems reasonable to want the
> >> first $x$ grefs seen by blkback to be treated as persistent, and any
> >> later ones to be non-persistent. Does that seem sensible?
> >
> >>From a resource usage pov, perhaps. But this will get the guest
> > entirely unpredictable performance. Plus I don't think 11Mb of
> > _virtual_ space is unacceptable overhead in a 64-bit kernel. If
> > you really want/need this in a 32-bit one, then perhaps some
> > other alternatives would be needed (and persistent grants may
> > not be the right approach there in the first place).
>
> It's not just virtual space. blkback in pvops kernels allocates its
> pages from the balloon and if there aren't enough ballooned out pages it
> has to allocate real pages (releasing the MFN back to Xen).
>
> Classic kernels didn't need to do this as there was an API for allocate
> new "empty" struct page's that get mapped into kernel space.
Can we ressurect/implement that in the new pvops? We could use the memory
hotplug mechanism to allocate "non-existent" memory.
>
> David
next prev parent reply other threads:[~2012-09-21 14:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 10:51 [PATCH] Persistent grant maps for xen blk drivers Oliver Chick
2012-09-19 11:17 ` Konrad Rzeszutek Wilk
2012-09-19 12:03 ` [Xen-devel] " Jan Beulich
2012-09-20 8:51 ` Oliver Chick
2012-09-20 9:11 ` Jan Beulich
2012-09-19 13:16 ` Pasi Kärkkäinen
2012-09-20 9:35 ` Oliver Chick
2012-09-20 10:09 ` Pasi Kärkkäinen
2012-09-19 14:11 ` Konrad Rzeszutek Wilk
2012-09-20 13:12 ` Oliver Chick
2012-09-20 13:52 ` Konrad Rzeszutek Wilk
2012-09-20 10:34 ` [Xen-devel] " David Vrabel
2012-09-20 11:30 ` Oliver Chick
2012-09-20 11:48 ` Jan Beulich
2012-09-20 13:49 ` Konrad Rzeszutek Wilk
2012-09-20 14:13 ` Oliver Chick
2012-09-20 16:10 ` Jan Beulich
2012-09-20 21:24 ` Konrad Rzeszutek Wilk
2012-09-21 7:18 ` Jan Beulich
2012-09-21 8:41 ` Oliver Chick
2012-09-21 9:41 ` Jan Beulich
2012-09-21 8:10 ` Ian Campbell
2012-09-21 14:26 ` Konrad Rzeszutek Wilk
2012-09-20 15:35 ` Jan Beulich
2012-09-21 12:23 ` David Vrabel
2012-09-21 14:27 ` Konrad Rzeszutek Wilk [this message]
2012-09-21 16:17 ` David Vrabel
2012-09-21 17:13 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921142733.GB3389@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=david.vrabel@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.chick@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox