From: "Maxin B. John" <maxin.john@gmail.com>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: "Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
"Wolfram Sang (embedded platforms)" <w.sang@pengutronix.de>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, "Jean Delvare (PC drivers,
core)" <khali@linux-fr.org>
Subject: [PATCH 2/2] i2c: busses: i2c-ocores: switch to devm_request_and_ioremap
Date: Sun, 23 Sep 2012 09:33:58 -0400 [thread overview]
Message-ID: <20120923133358.GA22861@linux-3ix0.site> (raw)
This drops a few lines of code and allows common APIs to handle those for us.
Signed-off-by: Maxin B. John <maxin.john@gmail.com>
---
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index bffd550..740a89b 100644
--- a/drivers/i2c/busses/i2c-ocores.c
+++ b/drivers/i2c/busses/i2c-ocores.c
@@ -283,18 +283,9 @@ static int __devinit ocores_i2c_probe(struct platform_device *pdev)
if (!i2c)
return -ENOMEM;
- if (!devm_request_mem_region(&pdev->dev, res->start,
- resource_size(res), pdev->name)) {
- dev_err(&pdev->dev, "Memory region busy\n");
+ i2c->base = devm_request_and_ioremap(&pdev->dev, res);
+ if (!i2c->base)
return -EBUSY;
- }
-
- i2c->base = devm_ioremap_nocache(&pdev->dev, res->start,
- resource_size(res));
- if (!i2c->base) {
- dev_err(&pdev->dev, "Unable to map registers\n");
- return -EIO;
- }
pdata = pdev->dev.platform_data;
if (pdata) {
next reply other threads:[~2012-09-23 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-23 13:33 Maxin B. John [this message]
2012-09-23 18:22 ` [PATCH 2/2] i2c: busses: i2c-ocores: switch to devm_request_and_ioremap Peter Korsgaard
2012-10-09 9:13 ` Maxin B John
2012-10-09 9:29 ` Peter Korsgaard
2012-11-13 11:20 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120923133358.GA22861@linux-3ix0.site \
--to=maxin.john@gmail.com \
--cc=ben-linux@fluff.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jacmet@sunsite.dk \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox