From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gorskin Ilya <revent82@gmail.com>
Cc: gregkh@linuxfoundation.org, klmckinney1@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:bcm: fix coding style issue in Bcmchar.c
Date: Mon, 24 Sep 2012 13:52:26 +0300 [thread overview]
Message-ID: <20120924105226.GI13767@mwanda> (raw)
In-Reply-To: <1348483483-32545-1-git-send-email-revent82@gmail.com>
On Mon, Sep 24, 2012 at 04:44:43PM +0600, Gorskin Ilya wrote:
> This is a patch to the Bcmchar.c file that fixes up a coding style
> warning found by the checkpatch.pl tool
>
The right way to fix this is to choose better variable names and to
get rid of the bogus BCM_DEBUG_PRINT() macro. It's better to leave
the warnings in for now.
checkpatch.pl is not the king of us.
regards,
dan carpenter
prev parent reply other threads:[~2012-09-24 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 10:44 [PATCH] Staging:bcm: fix coding style issue in Bcmchar.c Gorskin Ilya
2012-09-24 10:52 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924105226.GI13767@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=klmckinney1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=revent82@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox