From: Richard Cochran <richardcochran@gmail.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: David S Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] lxt PHY: Support for the buggy LXT973 rev A2
Date: Mon, 24 Sep 2012 20:30:35 +0200 [thread overview]
Message-ID: <20120924183035.GA2252@netboy.at.omicron.at> (raw)
In-Reply-To: <201209241400.q8OE0w38011790@localhost.localdomain>
On Mon, Sep 24, 2012 at 04:00:58PM +0200, Christophe Leroy wrote:
> diff -u a/drivers/net/phy/lxt.c b/drivers/net/phy/lxt.c
> --- a/drivers/net/phy/lxt.c 2012-09-23 03:08:48.000000000 +0200
> +++ b/drivers/net/phy/lxt.c 2012-09-23 03:18:00.000000000 +0200
...
> @@ -175,6 +292,16 @@
> .driver = { .owner = THIS_MODULE,},
> }, {
> .phy_id = 0x00137a10,
> + .name = "LXT973-A2",
> + .phy_id_mask = 0xffffffff,
> + .features = PHY_BASIC_FEATURES,
> + .flags = 0,
> + .probe = lxt973_probe,
> + .config_aneg = lxt973_config_aneg,
> + .read_status = lxt973a2_read_status,
I like this way of matching the A2 chips much better than what you had
before. But are you sure this will work correctly?
What do A3 chips have in the last nibble of phy_id?
> + .driver = { .owner = THIS_MODULE,},
> +}, {
> + .phy_id = 0x00137a10,
> .name = "LXT973",
> .phy_id_mask = 0xfffffff0,
> .features = PHY_BASIC_FEATURES,
Thanks,
Richard
next prev parent reply other threads:[~2012-09-24 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 14:00 [PATCH v4] lxt PHY: Support for the buggy LXT973 rev A2 Christophe Leroy
2012-09-24 14:13 ` David Laight
2012-09-24 14:40 ` leroy christophe
2012-09-24 18:30 ` Richard Cochran [this message]
2012-09-25 6:23 ` leroy christophe
2012-09-25 7:47 ` Richard Cochran
2012-09-27 21:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924183035.GA2252@netboy.at.omicron.at \
--to=richardcochran@gmail.com \
--cc=christophe.leroy@c-s.fr \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox