Re: sys_kcmp (was: Re: [PATCH 1/2] ARM: add finit_module syscall to ARM)

Ralf Baechle
2012-09-22T13:39:04Z

On Sat, Sep 22, 2012 at 02:20:46PM +0100, Russell King wrote:

> 2. There allegedly exists a patch to remove x86isms from sys_kcmp -
> allegedly also in akpm's tree. However, I've looked through the code in
> mainline, and nothing stands out. Ralf Beachle also said yesterday that
> he has looked through from the MIPS PoV and also can't see any x86isms,
> so we're both thinking that it should merely have the x86 dependency
> removed.
>
> 3. Until the x86 dependency is gone (that depends on what akpm proposes to
> do with the patches he's allegedly sitting on), non-x86 arches can only
> reserve the syscall, and add an IGNORE for it.

There is a weak definition provided in kernel/sys_ni.c so it actually can
be properly wired up in preparation for the day when the dependency in
Kconfig gets fixed.

> It would be good to at least get checksyscalls.sh fixed so arch maintainers
> get their warnings for new syscalls back.

Indeed. That script has become just too important.

Ralf