From: Oleg Nesterov <oleg@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Peter Zijlstra <peterz@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>, Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
rostedt <rostedt@goodmis.org>, dhowells <dhowells@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux-Next <linux-next@vger.kernel.org>
Subject: Re: [PATCH 1/4] task_work: make task_work_add() lockless
Date: Mon, 24 Sep 2012 22:37:50 +0200 [thread overview]
Message-ID: <20120924203750.GA28983@redhat.com> (raw)
In-Reply-To: <CAMuHMdU7D+SM=xCN9Yp0KuGwiod=RojWjkpdYT-Hw=v9iry66A@mail.gmail.com>
On 09/24, Geert Uytterhoeven wrote:
>
> On Sun, Aug 26, 2012 at 9:12 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> > + while ((work = ACCESS_ONCE(*pprev))) {
> > + read_barrier_depends();
Hmm. This should be smp_read_barrier_depends(), but this doesn't matter.
> Woops, h8300 doesn't have read_barrier_depends():
> kernel/task_work.c:38:3: error: implicit declaration of function
> 'read_barrier_depends' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[2]: *** [kernel/task_work.o] Error 1
Thanks...
> http://kisskb.ellerman.id.au/kisskb/buildresult/7238385/
>
> Perhaps an empty definition is fine? Most architectures have:
>
> #define read_barrier_depends() do { } while(0)
Yes. arch/h8300/include/asm/barrier.h has
#define smp_read_barrier_depends() read_barrier_depends()
so probably it should define read_barrier_depends() as well ?
Oleg.
next prev parent reply other threads:[~2012-09-24 20:36 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 20:36 lockdep trace from posix timers Dave Jones
2012-07-27 16:20 ` Dave Jones
2012-08-16 12:54 ` Ming Lei
2012-08-16 14:03 ` Dave Jones
2012-08-16 18:07 ` Peter Zijlstra
2012-08-17 15:14 ` Oleg Nesterov
2012-08-17 15:17 ` Oleg Nesterov
2012-08-17 16:40 ` task_work_add() should not succeed unconditionally (Was: lockdep trace from posix timers) Oleg Nesterov
2012-08-20 7:15 ` lockdep trace from posix timers Peter Zijlstra
2012-08-20 11:44 ` Peter Zijlstra
2012-08-20 11:46 ` Peter Zijlstra
2012-08-20 11:50 ` Peter Zijlstra
2012-08-20 12:19 ` Steven Rostedt
2012-08-20 12:20 ` Peter Zijlstra
2012-08-20 14:59 ` Oleg Nesterov
2012-08-20 15:10 ` Peter Zijlstra
2012-08-20 15:27 ` Peter Zijlstra
2012-08-20 15:32 ` Oleg Nesterov
2012-08-20 15:46 ` Peter Zijlstra
2012-08-20 15:58 ` Oleg Nesterov
2012-08-20 16:03 ` Peter Zijlstra
2012-08-20 15:05 ` Oleg Nesterov
2012-08-20 15:12 ` Peter Zijlstra
2012-08-20 15:41 ` Oleg Nesterov
2012-08-20 15:56 ` Peter Zijlstra
2012-08-20 16:10 ` Oleg Nesterov
2012-08-20 16:19 ` Peter Zijlstra
2012-08-20 16:23 ` Oleg Nesterov
2012-08-21 18:27 ` Oleg Nesterov
2012-08-21 18:34 ` Oleg Nesterov
2012-08-24 18:56 ` Oleg Nesterov
2012-08-26 19:11 ` [PATCH 0/4] (Was: lockdep trace from posix timers) Oleg Nesterov
2012-08-26 19:12 ` [PATCH 1/4] task_work: make task_work_add() lockless Oleg Nesterov
2012-09-14 6:08 ` [tip:core/urgent] task_work: Make " tip-bot for Oleg Nesterov
2012-09-24 19:27 ` [PATCH 1/4] task_work: make " Geert Uytterhoeven
2012-09-24 20:37 ` Oleg Nesterov [this message]
2012-08-26 19:12 ` [PATCH 2/4] task_work: task_work_add() should not succeed after exit_task_work() Oleg Nesterov
2012-09-14 6:09 ` [tip:core/urgent] " tip-bot for Oleg Nesterov
2012-08-26 19:12 ` [PATCH 3/4] task_work: revert d35abdb2 "hold task_lock around checks in keyctl" Oleg Nesterov
2012-09-14 6:10 ` [tip:core/urgent] task_work: Revert " hold " tip-bot for Oleg Nesterov
2012-08-26 19:12 ` [PATCH 4/4] task_work: simplify the usage in ptrace_notify() and get_signal_to_deliver() Oleg Nesterov
2012-09-14 6:11 ` [tip:core/urgent] task_work: Simplify " tip-bot for Oleg Nesterov
2012-09-06 18:01 ` [PATCH 0/4] (Was: lockdep trace from posix timers) Oleg Nesterov
2012-09-06 18:35 ` Peter Zijlstra
2012-09-07 13:13 ` Oleg Nesterov
2012-08-28 16:29 ` lockdep trace from posix timers Peter Zijlstra
2012-08-28 17:01 ` Oleg Nesterov
2012-08-28 17:12 ` Oleg Nesterov
2012-08-28 17:28 ` Peter Zijlstra
2012-08-29 15:25 ` Oleg Nesterov
2012-08-20 14:55 ` Oleg Nesterov
2012-08-20 15:43 ` Oleg Nesterov
2012-08-20 15:48 ` Peter Zijlstra
2012-08-20 15:58 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924203750.GA28983@redhat.com \
--to=oleg@redhat.com \
--cc=davej@redhat.com \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).