From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gorskin Ilya <revent82@gmail.com>
Cc: gregkh@linuxfoundation.org, klmckinney1@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Staging:bcm: fix coding style error in InterfaceIsr.c
Date: Tue, 25 Sep 2012 09:53:52 +0300 [thread overview]
Message-ID: <20120925065351.GQ4587@mwanda> (raw)
In-Reply-To: <1348549469-7222-2-git-send-email-revent82@gmail.com>
On Tue, Sep 25, 2012 at 11:04:29AM +0600, Gorskin Ilya wrote:
> This is a patch to the InterfaceIsr.c file that
> fixes up a coding style issues found by the checkpatch.pl tool
I'm afraid all these need to be redone along the lines which I
explained in my other email.
>
> Signed-off-by: Ilya Gorskin <revent82@gmail.com>
> ---
> drivers/staging/bcm/InterfaceIsr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/bcm/InterfaceIsr.c b/drivers/staging/bcm/InterfaceIsr.c
> index 4f78451..0e68485 100644
> --- a/drivers/staging/bcm/InterfaceIsr.c
> +++ b/drivers/staging/bcm/InterfaceIsr.c
> @@ -120,7 +120,7 @@ static void read_int_callback(struct urb *urb/*, struct pt_regs *regs*/)
> urb->status = STATUS_SUCCESS ;
> break ;
> /*return;*/
> - default:
> + default:
> /*This is required to check what is the defaults
> * conditions when it occurs..*/
> BCM_DEBUG_PRINT(Adapter, DBG_TYPE_TX, NEXT_SEND,
Checkpatch is a tool that finds ugly code. You've silenced the
warning. The code still looks like dog vommit, but now checkpatch
doesn't find it. Don't do that.
regards,
dan carpenter
next prev parent reply other threads:[~2012-09-25 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 5:04 [PATCH 2/3] Staging:bcm: fix coding style error in InterfaceIsr.c Gorskin Ilya
2012-09-25 5:04 ` [PATCH 3/3] " Gorskin Ilya
2012-09-25 6:53 ` Dan Carpenter [this message]
2012-09-25 6:37 ` [PATCH 2/3] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925065351.GQ4587@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=klmckinney1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=revent82@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).