* [PATCH] perf test: Fix build failure
@ 2012-09-25 2:20 Namhyung Kim
2012-09-25 10:45 ` Arnaldo Carvalho de Melo
2012-09-27 5:50 ` [tip:perf/core] " tip-bot for Namhyung Kim
0 siblings, 2 replies; 4+ messages in thread
From: Namhyung Kim @ 2012-09-25 2:20 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra, Paul Mackerras, Ingo Molnar, LKML, Namhyung Kim
From: Namhyung Kim <namhyung.kim@lge.com>
The commit 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint
format fields") added following build error:
CC builtin-test.o
builtin-test.c: In function ‘perf_evsel__test_field’:
builtin-test.c:1216:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
builtin-test.c: In function ‘perf_evsel__tp_sched_test’:
builtin-test.c:1242:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
make: *** [builtin-test.o] Error 1
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/builtin-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-test.c b/tools/perf/builtin-test.c
index 32caf13cfe01..78b47a75a7c9 100644
--- a/tools/perf/builtin-test.c
+++ b/tools/perf/builtin-test.c
@@ -1233,7 +1233,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name,
ret = -1;
}
- return 0;
+ return ret;
}
static int perf_evsel__tp_sched_test(void)
@@ -1286,7 +1286,7 @@ static int perf_evsel__tp_sched_test(void)
if (perf_evsel__test_field(evsel, "target_cpu", 4, true))
ret = -1;
- return 0;
+ return ret;
}
static struct test {
--
1.7.11.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] perf test: Fix build failure
2012-09-25 2:20 [PATCH] perf test: Fix build failure Namhyung Kim
@ 2012-09-25 10:45 ` Arnaldo Carvalho de Melo
2012-09-25 11:55 ` Ingo Molnar
2012-09-27 5:50 ` [tip:perf/core] " tip-bot for Namhyung Kim
1 sibling, 1 reply; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-09-25 10:45 UTC (permalink / raw)
To: Namhyung Kim
Cc: Peter Zijlstra, Paul Mackerras, Ingo Molnar, LKML, Namhyung Kim
Em Tue, Sep 25, 2012 at 11:20:28AM +0900, Namhyung Kim escreveu:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> The commit 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint
> format fields") added following build error:
>
> CC builtin-test.o
> builtin-test.c: In function ‘perf_evsel__test_field’:
> builtin-test.c:1216:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
> builtin-test.c: In function ‘perf_evsel__tp_sched_test’:
> builtin-test.c:1242:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> make: *** [builtin-test.o] Error 1
Interesting :-\
[acme@sandy linux]$ gcc --version
gcc (GCC) 4.4.6 20120305 (Red Hat 4.4.6-4)
Didn't catch this one...
Thanks,
- Arnaldo
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/builtin-test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-test.c b/tools/perf/builtin-test.c
> index 32caf13cfe01..78b47a75a7c9 100644
> --- a/tools/perf/builtin-test.c
> +++ b/tools/perf/builtin-test.c
> @@ -1233,7 +1233,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name,
> ret = -1;
> }
>
> - return 0;
> + return ret;
> }
>
> static int perf_evsel__tp_sched_test(void)
> @@ -1286,7 +1286,7 @@ static int perf_evsel__tp_sched_test(void)
> if (perf_evsel__test_field(evsel, "target_cpu", 4, true))
> ret = -1;
>
> - return 0;
> + return ret;
> }
>
> static struct test {
> --
> 1.7.11.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] perf test: Fix build failure
2012-09-25 10:45 ` Arnaldo Carvalho de Melo
@ 2012-09-25 11:55 ` Ingo Molnar
0 siblings, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2012-09-25 11:55 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Namhyung Kim, Peter Zijlstra, Paul Mackerras, LKML, Namhyung Kim
* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:
> Em Tue, Sep 25, 2012 at 11:20:28AM +0900, Namhyung Kim escreveu:
> > From: Namhyung Kim <namhyung.kim@lge.com>
> >
> > The commit 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint
> > format fields") added following build error:
> >
> > CC builtin-test.o
> > builtin-test.c: In function ‘perf_evsel__test_field’:
> > builtin-test.c:1216:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
> > builtin-test.c: In function ‘perf_evsel__tp_sched_test’:
> > builtin-test.c:1242:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
> > cc1: all warnings being treated as errors
> > make: *** [builtin-test.o] Error 1
>
>
> Interesting :-\
>
> [acme@sandy linux]$ gcc --version
> gcc (GCC) 4.4.6 20120305 (Red Hat 4.4.6-4)
This caught it here:
gcc version 4.7.0 20120507 (Red Hat 4.7.0-5) (GCC)
Thanks,
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:perf/core] perf test: Fix build failure
2012-09-25 2:20 [PATCH] perf test: Fix build failure Namhyung Kim
2012-09-25 10:45 ` Arnaldo Carvalho de Melo
@ 2012-09-27 5:50 ` tip-bot for Namhyung Kim
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Namhyung Kim @ 2012-09-27 5:50 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, linux-kernel, paulus, hpa, mingo, a.p.zijlstra,
namhyung.kim, namhyung, tglx
Commit-ID: af9da88f14cbe6882b13492b59b3363682427b4d
Gitweb: http://git.kernel.org/tip/af9da88f14cbe6882b13492b59b3363682427b4d
Author: Namhyung Kim <namhyung.kim@lge.com>
AuthorDate: Tue, 25 Sep 2012 11:20:28 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 25 Sep 2012 07:45:59 -0300
perf test: Fix build failure
The commit 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint
format fields") added following build error:
CC builtin-test.o
builtin-test.c: In function ‘perf_evsel__test_field’:
builtin-test.c:1216:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
builtin-test.c: In function ‘perf_evsel__tp_sched_test’:
builtin-test.c:1242:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
make: *** [builtin-test.o] Error 1
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1348539628-3821-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-test.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-test.c b/tools/perf/builtin-test.c
index 32caf13..78b47a7 100644
--- a/tools/perf/builtin-test.c
+++ b/tools/perf/builtin-test.c
@@ -1233,7 +1233,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name,
ret = -1;
}
- return 0;
+ return ret;
}
static int perf_evsel__tp_sched_test(void)
@@ -1286,7 +1286,7 @@ static int perf_evsel__tp_sched_test(void)
if (perf_evsel__test_field(evsel, "target_cpu", 4, true))
ret = -1;
- return 0;
+ return ret;
}
static struct test {
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-27 5:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-25 2:20 [PATCH] perf test: Fix build failure Namhyung Kim
2012-09-25 10:45 ` Arnaldo Carvalho de Melo
2012-09-25 11:55 ` Ingo Molnar
2012-09-27 5:50 ` [tip:perf/core] " tip-bot for Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).