From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Feng Tang <feng.tang@intel.com>,
mingo@elte.hu, a.p.zijlstra@chello.nl, andi@firstfloor.org,
David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org
Subject: perf tools regression testing was Re: [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c
Date: Tue, 25 Sep 2012 10:30:15 -0300 [thread overview]
Message-ID: <20120925133015.GA2892@infradead.org> (raw)
In-Reply-To: <1348577942.1877.32.camel@leonhard>
Em Tue, Sep 25, 2012 at 09:59:02PM +0900, Namhyung Kim escreveu:
> 2012-09-25 (화), 08:05 -0300, Arnaldo Carvalho de Melo:
> > Em Tue, Sep 25, 2012 at 10:25:13AM +0900, Namhyung Kim escreveu:
> > > On Mon, 24 Sep 2012 13:02:39 -0300, Arnaldo Carvalho de Melo wrote:
> > > > Em Mon, Sep 24, 2012 at 11:24:03PM +0800, Feng Tang escreveu:
> > > >> Which looks more natural
> > > > It is there to avoid dragging the hist code into the python binding :-\
> > > Hmm... it's so hairy. Can't we do better?
> > We always can do better :-)
> > I just stated why it was at that place.
> > When doing refactorings we're all the time trying to make it better in
> > many senses, one of them is trying to isolate code that is useful in a
> > general way and thus should be made available via a library/scripting
> > binding.
> Yeah, but the isolation sometimes got broken as code getting added like
> this. So we need a automatic way of detecting breakage.
Agreed.
> I thought about adding a perf test entry running python/twatch.py, but
> it will not work for an installed perf binary since it cannot find the
> twatch.py script and perf.so extension files which are not installed.
I thought about doing it the way 'perf script' works with python, i.e.
calling the python interpreter, setting the PYTHONPATH thru it, then
asking for 'use python' to happen, catch the result.
> Now I'm thinking of making it build-time test so that it can be executed
> by make when specific argument is given - e.g. make C=1 ?
I think there is room for a 'make -C tools/perf check' that would use
the 'expect' tool to do not just this but also run record, report, etc
and check its output against what is expected, perf test is ok for
checking the APIs, but we need a test suite for the actual builtins as
called from the command line.
- Arnaldo
next prev parent reply other threads:[~2012-09-25 13:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 15:24 [PATCH v3 0/9] perf tools: Add script browser and runtime data file switch Feng Tang
2012-09-24 15:24 ` [PATCH v3 1/9] perf hists: Move hists_init() from util/evsel.c to util/hist.c Feng Tang
2012-09-24 16:02 ` Arnaldo Carvalho de Melo
2012-09-25 1:25 ` Namhyung Kim
2012-09-25 11:05 ` Arnaldo Carvalho de Melo
2012-09-25 12:59 ` Namhyung Kim
2012-09-25 13:30 ` Arnaldo Carvalho de Melo [this message]
2012-09-25 13:47 ` perf tools regression testing was " Namhyung Kim
2012-09-25 14:10 ` Arnaldo Carvalho de Melo
2012-09-25 8:03 ` Feng Tang
2012-09-24 15:24 ` [PATCH v3 2/9] perf tool: Add a global variable "const char *input_name" Feng Tang
2012-09-24 15:24 ` [PATCH v3 3/9] perf script: Add more filter to find_scripts() Feng Tang
2012-09-25 1:47 ` Namhyung Kim
2012-09-26 8:56 ` Feng Tang
2012-09-27 4:45 ` Namhyung Kim
2012-09-27 10:39 ` Namhyung Kim
2012-09-24 15:24 ` [PATCH v3 4/9] perf ui/browser: Add a browser for perf script Feng Tang
2012-09-24 15:24 ` [PATCH v3 5/9] perf ui/browser: Integrate script browser into annotation browser Feng Tang
2012-09-24 15:24 ` [PATCH v3 6/9] perf ui/browser: Integrate script browser into main hists browser Feng Tang
2012-09-24 15:24 ` [PATCH v3 7/9] perf header: Add check_perf_magic() func Feng Tang
2012-09-24 16:01 ` Arnaldo Carvalho de Melo
2012-09-25 2:07 ` Namhyung Kim
2012-09-25 8:21 ` Feng Tang
2012-09-25 11:22 ` Arnaldo Carvalho de Melo
2012-09-24 15:24 ` [PATCH v3 8/9] perf hists browser: Add option for runtime switching perf data file Feng Tang
2012-09-25 2:11 ` Namhyung Kim
2012-09-25 8:20 ` Feng Tang
2012-09-25 11:17 ` Arnaldo Carvalho de Melo
2012-09-26 7:57 ` Feng Tang
2012-09-27 4:02 ` Namhyung Kim
2012-09-27 5:43 ` Feng Tang
2012-09-24 15:24 ` [PATCH v3 9/9] perf report: Enable the runtime switching of " Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925133015.GA2892@infradead.org \
--to=acme@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=feng.tang@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox