From: Greg KH <gregkh@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Steven Rostedt <srostedt@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: ktest.pl always returns 0?
Date: Wed, 26 Sep 2012 09:21:45 -0700 [thread overview]
Message-ID: <20120926162145.GA32277@kroah.com> (raw)
In-Reply-To: <1348616910.22822.30.camel@gandalf.local.home>
On Tue, Sep 25, 2012 at 07:48:30PM -0400, Steven Rostedt wrote:
> I just forced a build failure to see what ktest would show. This is my
> result:
>
> cp /home/rostedt/work/git/configs/ixf/config-use /home/rostedt/work/git/nobackup/ixf/trace/.config ... SUCCESS
> touch /home/rostedt/work/git/nobackup/ixf/trace/.config ... SUCCESS
> Applying minimum configurations into /home/rostedt/work/git/nobackup/ixf/trace/.config.new
> mv /home/rostedt/work/git/nobackup/ixf/trace/.config.new /home/rostedt/work/git/nobackup/ixf/trace/.config ... SUCCESS
> GCC_VERSION=4.6.0 distmake-64 O=/home/rostedt/work/git/nobackup/ixf/trace oldnoconfig ... SUCCESS
> GCC_VERSION=4.6.0 distmake-64 O=/home/rostedt/work/git/nobackup/ixf/trace -j40 ... FAILED!
> CRITICAL FAILURE... failed build
> See /home/rostedt/work/git/nobackup/ixf/ixf.log for more info.
> failed build
> [rostedt@fedora git]$ echo $?
> 25
>
>
> So it seems that if DIE_ON_FAILURE is set, it returns non-zero error.
Ugh, you are right, my mistake, it was a bug in my script that I was not
checking the correct return value (for those wondering, my bash script
was writing out a bash script that then got run, I forgot to escape the
"$?" properly, so it was being intrepreted when written out and not when
run.
So sorry for the noise, all is now working just fine.
greg "I should stick to C" k-h
prev parent reply other threads:[~2012-09-26 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 18:00 ktest.pl always returns 0? Greg KH
2012-09-25 18:15 ` Steven Rostedt
2012-09-25 19:40 ` Greg KH
2012-09-25 20:33 ` Steven Rostedt
2012-09-25 23:48 ` Steven Rostedt
2012-09-26 16:21 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120926162145.GA32277@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox