From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757108Ab2IZQ3r (ORCPT ); Wed, 26 Sep 2012 12:29:47 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:55826 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753314Ab2IZQ3q (ORCPT ); Wed, 26 Sep 2012 12:29:46 -0400 Date: Wed, 26 Sep 2012 09:29:41 -0700 From: Greg Kroah-Hartman To: Calvin Walton Cc: Minchan Kim , Jens Axboe , Nitin Gupta , Konrad Rzeszutek Wilk , Seth Jennings , Dan Magenheimer , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] zram: select ZSMALLOC when ZRAM is configured Message-ID: <20120926162941.GA29694@kroah.com> References: <1348649419-16494-1-git-send-email-minchan@kernel.org> <1348649419-16494-4-git-send-email-minchan@kernel.org> <20120926161539.GA30132@kroah.com> <1348676615.2552.5.camel@ayu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1348676615.2552.5.camel@ayu> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 26, 2012 at 12:23:35PM -0400, Calvin Walton wrote: > On Wed, 2012-09-26 at 09:15 -0700, Greg Kroah-Hartman wrote: > > On Wed, Sep 26, 2012 at 05:50:19PM +0900, Minchan Kim wrote: > > > At the monent, we can configure zram in driver/block once zsmalloc > > > in /lib menu is configured firstly. It's not convenient. > > > > > > User can configure zram in driver/block regardless of zsmalloc enabling > > > by this patch. > > > > > > Signed-off-by: Minchan Kim > > > --- > > > drivers/block/zram/Kconfig | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig > > > index be5abe8..ee23a86 100644 > > > --- a/drivers/block/zram/Kconfig > > > +++ b/drivers/block/zram/Kconfig > > > @@ -1,6 +1,7 @@ > > > config ZRAM > > > tristate "Compressed RAM block device support" > > > - depends on BLOCK && SYSFS && ZSMALLOC > > > + depends on BLOCK && SYSFS > > > + select ZSMALLOC > > > > As ZSMALLOC is dependant on CONFIG_STAGING, this isn't going to work at > > all, sorry. > > Perhaps you missed [PATCH 1/3] zsmalloc: promote to lib/ ? The first > patch in this series moves zsmalloc out of the staging directory, and > removes the dependency on CONFIG_STAGING. Ah, I did, thanks. For 3.7, it's too late to be moving stuff out of staging to the "real" part of the kernel as 3.6 is about to be released. Possibly, if everyone agrees with this, after 3.7 is out we can do this for 3.8, ok? thanks, greg k-h