From: Felipe Balbi <balbi@ti.com>
To: viresh kumar <viresh.kumar@linaro.org>
Cc: balbi@ti.com, Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org,
spear-devel <spear-devel@list.st.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCHv3 1/7] dmaengine: dw_dmac: use helper macro module_platform_driver()
Date: Thu, 27 Sep 2012 11:16:29 +0300 [thread overview]
Message-ID: <20120927081627.GP12592@arwen.pp.htv.fi> (raw)
In-Reply-To: <CAOh2x==i26PjSWzFYE+qzAThUL1fiFy8D17NtQGZqznGzRVApw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
On Thu, Sep 27, 2012 at 01:46:17PM +0530, viresh kumar wrote:
> On Thu, Sep 27, 2012 at 1:10 PM, Felipe Balbi <balbi@ti.com> wrote:
> >> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
>
> >> @@ -1700,6 +1700,7 @@ MODULE_DEVICE_TABLE(of, dw_dma_id_table);
> >> #endif
> >>
> >> static struct platform_driver dw_driver = {
> >> + .probe = dw_probe,
> >
> > probe's in __init section. This is wrong. You need to change probe
> > __devinit.
>
> Good one. How can i miss it. :(
>
> @Andy: Please add my Acked-by: after this change.
after this change you can also add:
Reviewed-by: Felipe Balbi <balbi@ti.com>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-27 8:21 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 7:31 [PATCHv3 0/7] dw_dmac: split the driver and introduce PCI part Andy Shevchenko
2012-09-27 7:31 ` [PATCHv3 1/7] dmaengine: dw_dmac: use helper macro module_platform_driver() Andy Shevchenko
2012-09-27 7:40 ` Felipe Balbi
2012-09-27 8:16 ` viresh kumar
2012-09-27 8:16 ` Felipe Balbi [this message]
2012-10-01 10:47 ` Andy Shevchenko
2012-10-01 13:05 ` Felipe Balbi
2012-09-27 7:31 ` [PATCHv3 2/7] dmaengine: dw_dmac: add module alias Andy Shevchenko
2012-09-27 8:16 ` viresh kumar
2012-09-27 8:16 ` Felipe Balbi
2012-09-27 7:31 ` [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency Andy Shevchenko
2012-09-27 7:42 ` Felipe Balbi
2012-09-27 8:04 ` Andy Shevchenko
2012-09-27 8:02 ` Felipe Balbi
2012-09-27 8:17 ` viresh kumar
2012-09-27 8:17 ` Felipe Balbi
2012-09-27 7:31 ` [PATCHv3 4/7] dmaengine: dw_dmac: amend description and indentation Andy Shevchenko
2012-09-27 7:45 ` Felipe Balbi
2012-09-27 8:19 ` viresh kumar
2012-09-27 8:36 ` Andy Shevchenko
2012-09-27 7:31 ` [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver Andy Shevchenko
2012-09-27 7:49 ` Felipe Balbi
2012-09-27 8:08 ` Andy Shevchenko
2012-09-27 8:09 ` Felipe Balbi
2012-09-27 8:44 ` Vinod Koul
2012-09-27 9:43 ` Andy Shevchenko
2012-09-27 10:01 ` Vinod Koul
2012-09-27 10:11 ` viresh kumar
2012-09-27 10:32 ` Vinod Koul
2012-10-03 13:40 ` Andy Shevchenko
2012-10-08 10:17 ` Andy Shevchenko
2012-10-08 10:49 ` Viresh Kumar
2012-10-08 12:46 ` Andy Shevchenko
2012-10-08 13:27 ` Viresh Kumar
2012-10-24 11:13 ` Vinod Koul
2012-10-30 15:05 ` Andy Shevchenko
2012-10-30 15:19 ` Viresh Kumar
2012-10-30 15:39 ` Andy Shevchenko
2012-09-27 7:32 ` [PATCHv3 6/7] dma: move dw_dmac driver to an own directory Andy Shevchenko
2012-09-27 7:50 ` Felipe Balbi
2012-09-27 8:22 ` viresh kumar
2012-09-27 8:39 ` Felipe Balbi
2012-09-27 7:32 ` [PATCHv3 7/7] MAINTAINERS: add recently created files to dw_dmac section Andy Shevchenko
2012-09-27 7:51 ` Felipe Balbi
2012-09-27 8:12 ` viresh kumar
2012-09-27 8:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927081627.GP12592@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox