From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Peter Huewe <peterhuewe@gmx.de>,
Jean Delvare <khali@linux-fr.org>
Cc: linux-s390@vger.kernel.org,
Linux-Next <linux-next@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [-next]: s390 *_irq() link errors
Date: Thu, 27 Sep 2012 13:51:34 +0200 [thread overview]
Message-ID: <20120927115134.GA5654@osiris.de.ibm.com> (raw)
In-Reply-To: <CAMuHMdXqsPgfToNyjbxJ-WM=-kEEvAweE03wb3vtkwVO+-RR3A@mail.gmail.com>
On Sun, Sep 16, 2012 at 09:07:54PM +0200, Geert Uytterhoeven wrote:
> After applying http://www.spinics.net/lists/linux-next/msg21973.html,
> the s390 allmodconfig build in linux-next fails in the linking stage with:
>
> ERROR: "free_irq" [drivers/power/smb347-charger.ko] undefined!
> ERROR: "free_irq" [drivers/power/sbs-battery.ko] undefined!
> ERROR: "enable_irq" [drivers/power/max17042_battery.ko] undefined!
> ERROR: "request_irq" [drivers/power/max17042_battery.ko] undefined!
> ERROR: "free_irq" [drivers/power/max17042_battery.ko] undefined!
> ERROR: "disable_irq" [drivers/power/max17042_battery.ko] undefined!
> ERROR: "request_irq" [drivers/power/lp8727_charger.ko] undefined!
> ERROR: "free_irq" [drivers/power/lp8727_charger.ko] undefined!
> ERROR: "request_irq" [drivers/nfc/pn544_hci.ko] undefined!
> ERROR: "free_irq" [drivers/nfc/pn544_hci.ko] undefined!
> ERROR: "request_irq" [drivers/nfc/pn544.ko] undefined!
> ERROR: "free_irq" [drivers/nfc/pn544.ko] undefined!
> ERROR: "request_irq" [drivers/misc/fsa9480.ko] undefined!
> ERROR: "free_irq" [drivers/misc/fsa9480.ko] undefined!
> ERROR: "request_irq" [drivers/misc/bh1770glc.ko] undefined!
> ERROR: "free_irq" [drivers/misc/bh1770glc.ko] undefined!
> ERROR: "request_irq" [drivers/misc/apds990x.ko] undefined!
> ERROR: "free_irq" [drivers/misc/apds990x.ko] undefined!
>
> What should these drivers depend on? GENERIC_HARDIRQS?
Probably, but...
> S390 is the only non-GENERIC_HARDIRQS architecture left, but all
> other former non-GENERIC_HARDIRQS architectures did provide e.g. request_irq()
> and free_irq().
All of this started because I2C lost its HAS_IOMEM dependency. Can't
we simply add an !S390 dependency instead and all is well? :)
Something like below?
>From 24c68e72b6198b8412a8605fac7d9c90796502ac Mon Sep 17 00:00:00 2001
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Date: Thu, 27 Sep 2012 13:37:14 +0200
Subject: [PATCH] i2c: Make I2C unavailable on s390 again
"i2c: Make I2C available on UML" removed the IOMEM dependency from I2C which
resulted in I2C being avaible on s390 and causing allmodconfig and allyesconfig
builds to fail:
drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_write':
drivers/misc/altera-stapl/altera-lpt.c:34:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
Adding a HAS_PORT dependency to that driver reveals that there are lots
of other build errors waiting for discovery because of this change since
s390 does not support generic hardirqs:
ERROR: "free_irq" [drivers/power/smb347-charger.ko] undefined!
ERROR: "free_irq" [drivers/power/sbs-battery.ko] undefined!
ERROR: "enable_irq" [drivers/power/max17042_battery.ko] undefined!
ERROR: "request_irq" [drivers/power/max17042_battery.ko] undefined!
ERROR: "free_irq" [drivers/power/max17042_battery.ko] undefined!
ERROR: "disable_irq" [drivers/power/max17042_battery.ko] undefined!
ERROR: "request_irq" [drivers/power/lp8727_charger.ko] undefined!
ERROR: "free_irq" [drivers/power/lp8727_charger.ko] undefined!
ERROR: "request_irq" [drivers/nfc/pn544_hci.ko] undefined!
ERROR: "free_irq" [drivers/nfc/pn544_hci.ko] undefined!
ERROR: "request_irq" [drivers/nfc/pn544.ko] undefined!
ERROR: "free_irq" [drivers/nfc/pn544.ko] undefined!
ERROR: "request_irq" [drivers/misc/fsa9480.ko] undefined!
ERROR: "free_irq" [drivers/misc/fsa9480.ko] undefined!
ERROR: "request_irq" [drivers/misc/bh1770glc.ko] undefined!
ERROR: "free_irq" [drivers/misc/bh1770glc.ko] undefined!
ERROR: "request_irq" [drivers/misc/apds990x.ko] undefined!
ERROR: "free_irq" [drivers/misc/apds990x.ko] undefined!
Since UML seems to need generic I2C support, but lot's of now available
drivers fail to compile on s390, just add a !S390 dependency.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Peter Huewe <peterhuewe@gmx.de>
Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
drivers/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
index 17b35c1..2f8c76b 100644
--- a/drivers/i2c/Kconfig
+++ b/drivers/i2c/Kconfig
@@ -4,6 +4,7 @@
menuconfig I2C
tristate "I2C support"
+ depends on !S390
select RT_MUTEXES
---help---
I2C (pronounce: I-squared-C) is a slow serial bus protocol used in
--
1.7.11.7
next prev parent reply other threads:[~2012-09-27 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-16 19:07 [-next]: s390 *_irq() link errors Geert Uytterhoeven
2012-09-27 11:51 ` Heiko Carstens [this message]
2012-09-29 16:39 ` Geert Uytterhoeven
2012-09-30 8:53 ` Jean Delvare
2012-09-30 9:08 ` Geert Uytterhoeven
2012-09-30 9:20 ` Jean Delvare
2012-09-30 9:35 ` Geert Uytterhoeven
2012-09-30 10:05 ` Jean Delvare
2012-09-30 11:08 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927115134.GA5654@osiris.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=geert@linux-m68k.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox