From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Pavel Emelyanov <xemul@parallels.com>,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [RFC] tty: Add get- ioctls to fetch tty status
Date: Thu, 27 Sep 2012 20:06:46 +0400 [thread overview]
Message-ID: <20120927160646.GO6618@moon> (raw)
In-Reply-To: <20120927170037.196ea446@pyramind.ukuu.org.uk>
On Thu, Sep 27, 2012 at 05:00:37PM +0100, Alan Cox wrote:
> > > Otherwise - TICOGPKT is specific to pty devices. Please therefore put it
> > > in the pty.c code and note that not all platforms use asm-geneic TTY
> > > ioctls so check carefully they all build.
> >
> > I put it into tty_ioctl.c simply because TIOCPKT was there already so
> > I thought it's good idea to keep them close to each other in code.
>
> Perhaps we should move TIOCPKT out as well?
OK, so I'll do two patches instead of squashing everything on one patch.
Btw, as far as I see wee are zeroifying tty_struct always twice,
first in alloc_tty_struct and then in initialize_tty_struct again.
And alloc_tty_struct + initialize_tty_struct always used as a tuple
in current code, so I presume they might be squashed in one helper
instead to eliminate overhead, but it's different task.
next prev parent reply other threads:[~2012-09-27 16:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 9:56 [RFC] tty: Add get- ioctls to fetch tty status Cyrill Gorcunov
2012-09-13 11:46 ` Jiri Slaby
2012-09-13 11:51 ` Cyrill Gorcunov
2012-09-13 12:51 ` Alan Cox
2012-09-13 12:54 ` Cyrill Gorcunov
2012-09-13 16:25 ` Alan Cox
2012-09-13 16:41 ` Cyrill Gorcunov
2012-09-22 18:06 ` Cyrill Gorcunov
2012-09-22 20:07 ` Greg Kroah-Hartman
2012-09-22 20:11 ` Cyrill Gorcunov
2012-09-22 21:52 ` Cyrill Gorcunov
2012-09-23 1:09 ` Greg Kroah-Hartman
2012-09-23 6:40 ` Cyrill Gorcunov
2012-09-23 14:46 ` H. Peter Anvin
2012-09-23 15:21 ` Cyrill Gorcunov
2012-09-24 14:14 ` Cyrill Gorcunov
2012-09-27 14:05 ` Cyrill Gorcunov
2012-09-27 14:14 ` Alan Cox
2012-09-27 14:14 ` Cyrill Gorcunov
2012-09-27 14:17 ` H. Peter Anvin
2012-09-27 14:21 ` Cyrill Gorcunov
2012-09-27 14:43 ` H. Peter Anvin
2012-09-27 14:48 ` Cyrill Gorcunov
2012-09-27 15:05 ` H. Peter Anvin
2012-09-27 15:13 ` Alan Cox
2012-09-27 15:23 ` Cyrill Gorcunov
2012-09-27 16:00 ` Alan Cox
2012-09-27 16:06 ` Cyrill Gorcunov [this message]
2012-09-27 15:47 ` Cyrill Gorcunov
2012-09-22 23:15 ` Alan Cox
2012-09-23 1:43 ` Eric W. Biederman
2012-09-23 6:40 ` Cyrill Gorcunov
2012-09-23 14:44 ` H. Peter Anvin
2012-09-23 15:22 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927160646.GO6618@moon \
--to=gorcunov@openvz.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).