Re: [patch 1/2] tty: pty - Move TIOCPKT handling into pty.c

Cyrill Gorcunov
2012-09-27T18:19:04Z

On Thu, Sep 27, 2012 at 11:14:17AM -0700, Greg KH wrote:
> On Thu, Sep 27, 2012 at 09:37:14PM +0400, Cyrill Gorcunov wrote:
> > On Thu, Sep 27, 2012 at 07:33:27PM +0200, Jiri Slaby wrote:
> > >
> > > Hi!
> > >
> > > This check is not needed as the ioctls are master-only.
> >
> > Hi, thanks, Jiri, i'll update (was hurry to provide patches
> > so missed this ;)
>
> Don't rush, anything you do here will be for 3.8, not 3.7, it's too late
> for that, the tty tree already has lots of changes for 3.7.
>
> So take your time please.

Sure, patching other archs ioctls is not as simple as I thought,
need to recheck everything and I think better to do all this in
3 patches

- move ptkmode setting into pty
- introduce new ioctl codes (including patching other archs)
- add real handlers for this new ioctl codes

this will help for bisection.

Cyrill