From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754413Ab2I0STE (ORCPT ); Thu, 27 Sep 2012 14:19:04 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:33418 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753993Ab2I0STC (ORCPT ); Thu, 27 Sep 2012 14:19:02 -0400 Date: Thu, 27 Sep 2012 22:18:58 +0400 From: Cyrill Gorcunov To: Greg KH Cc: Jiri Slaby , linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk, hpa@zytor.com, xemul@parallels.com Subject: Re: [patch 1/2] tty: pty - Move TIOCPKT handling into pty.c Message-ID: <20120927181858.GV6618@moon> References: <20120927165958.287690622@openvz.org> <20120927170137.722717394@openvz.org> <50648DE7.2060904@suse.cz> <20120927173714.GQ6618@moon> <20120927181417.GA10536@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120927181417.GA10536@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 27, 2012 at 11:14:17AM -0700, Greg KH wrote: > On Thu, Sep 27, 2012 at 09:37:14PM +0400, Cyrill Gorcunov wrote: > > On Thu, Sep 27, 2012 at 07:33:27PM +0200, Jiri Slaby wrote: > > > > > > Hi! > > > > > > This check is not needed as the ioctls are master-only. > > > > Hi, thanks, Jiri, i'll update (was hurry to provide patches > > so missed this ;) > > Don't rush, anything you do here will be for 3.8, not 3.7, it's too late > for that, the tty tree already has lots of changes for 3.7. > > So take your time please. Sure, patching other archs ioctls is not as simple as I thought, need to recheck everything and I think better to do all this in 3 patches - move ptkmode setting into pty - introduce new ioctl codes (including patching other archs) - add real handlers for this new ioctl codes this will help for bisection. Cyrill