[PATCH] AMD, iommu: Fix features reporting

[PATCH] AMD, iommu: Fix features reporting

[Borislav Petkov]

From: Borislav Petkov <borislav.petkov@amd.com>

When the AMD IOMMU doesn't have extended features, an empty line
gets issued in dmesg like so:

[    3.061417] AMD-Vi: Found IOMMU at 0000:00:00.2 cap 0x40
[    3.066757] 							<---
[    3.068294] pci 0000:00:00.2: irq 72 for MSI/MSI-X
[    3.081213] AMD-Vi: Lazy IO/TLB flushing enabled

Fix it.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
 drivers/iommu/amd_iommu_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
index 18a89b760aaa..378aff1ff1e7 100644
--- a/drivers/iommu/amd_iommu_init.c
+++ b/drivers/iommu/amd_iommu_init.c
@@ -1115,8 +1115,8 @@ static void print_iommu_info(void)
 				if (iommu_feature(iommu, (1ULL << i)))
 					pr_cont(" %s", feat_str[i]);
 			}
-		}
 		pr_cont("\n");
+		}
 	}
 }
 
-- 
1.7.11.rc1

Re: [PATCH] AMD, iommu: Fix features reporting

[Joerg Roedel]

On Fri, Sep 28, 2012 at 04:22:26PM +0200, Borislav Petkov wrote:
> From: Borislav Petkov <borislav.petkov@amd.com>
> 
> When the AMD IOMMU doesn't have extended features, an empty line
> gets issued in dmesg like so:
> 
> [    3.061417] AMD-Vi: Found IOMMU at 0000:00:00.2 cap 0x40
> [    3.066757] 							<---
> [    3.068294] pci 0000:00:00.2: irq 72 for MSI/MSI-X
> [    3.081213] AMD-Vi: Lazy IO/TLB flushing enabled
> 
> Fix it.
> 
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>

Applied, thanks :)

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632