From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758224Ab2I1Ofn (ORCPT ); Fri, 28 Sep 2012 10:35:43 -0400 Received: from tx2ehsobe005.messaging.microsoft.com ([65.55.88.15]:14123 "EHLO tx2outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757329Ab2I1Ofm (ORCPT ); Fri, 28 Sep 2012 10:35:42 -0400 X-Forefront-Antispam-Report: CIP:163.181.249.108;KIP:(null);UIP:(null);IPV:NLI;H:ausb3twp01.amd.com;RD:none;EFVD:NLI X-SpamScore: -6 X-BigFish: VPS-6(zz98dI103dK1432Izz1202h1d1ah1d2ahzz8275bh15d4Iz2dh668h839h944hd25he5bhf0ah11b5h121eh1220h1288h12a5h12a9h12bdh137ah13b6h1155h) X-WSS-ID: 0MB2DVB-01-6R2-02 X-M-MSG: Date: Fri, 28 Sep 2012 16:35:36 +0200 From: Joerg Roedel To: Konrad Rzeszutek Wilk CC: , Subject: Re: [PATCH 01/16] iommu/amd: Keep track of HPET and IOAPIC device ids Message-ID: <20120928143536.GE4009@amd.com> References: <1348835046-3262-1-git-send-email-joerg.roedel@amd.com> <1348835046-3262-2-git-send-email-joerg.roedel@amd.com> <20120928140833.GB7483@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20120928140833.GB7483@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: amd.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 28, 2012 at 10:08:34AM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 28, 2012 at 02:23:51PM +0200, Joerg Roedel wrote: > > + if (type != 1 && type != 2) > > + return -EINVAL; > > Should this be perhaps an enum? or #define? Yup, that'll be better. I change it. > Reviwed-by: Konrad Rzeszutek Wilk Thanks! Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632