From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759361Ab2I2Ias (ORCPT ); Sat, 29 Sep 2012 04:30:48 -0400 Received: from smtprelay03.ispgateway.de ([80.67.31.37]:51463 "EHLO smtprelay03.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755313Ab2I2Iap (ORCPT ); Sat, 29 Sep 2012 04:30:45 -0400 X-Greylist: delayed 337 seconds by postgrey-1.27 at vger.kernel.org; Sat, 29 Sep 2012 04:30:45 EDT Date: Sat, 29 Sep 2012 09:24:59 +0100 From: Bernhard Walle To: Ingo Molnar Cc: Jean Delvare , linux-kernel@vger.kernel.org, x86@kernel.org, Michal Marek , Ralf Baechle Subject: Re: [PATCH] kbuild: Fix gcc -x syntax Message-ID: <20120929082459.GA10005@brahe.fritz.box> Mail-Followup-To: Ingo Molnar , Jean Delvare , linux-kernel@vger.kernel.org, x86@kernel.org, Michal Marek , Ralf Baechle References: <1348859536.22956.4.camel@amber.site> <20120929073749.GA7672@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120929073749.GA7672@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Df-Sender: MTIyNzgwNg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Ingo Molnar [2012-09-29 08:37]: > * Jean Delvare wrote: > > > The correct syntax for gcc -x is "gcc -x assembler", not "gcc > > -xassembler". Even though the latter happens to work, the > > former is what is documented in the manual page and thus what > > gcc wrappers such as icecream do expect. > > > > This isn't a cosmetic change. The missing space prevents > > icecream from recognizing compilation tasks it can't handle, > > leading to silent kernel miscompilations. > > Although we can apply this patch, it won't solve the problem of > building older kernels (and bisecting, etc.). > > Wouldn't it be prudent to increase the compatibility of > icecream, so that it accepts what GCC accepts in practice, > such as -xassembler? Wouldn't it make sense to do both? Using the documented syntax in the build system *and* increase compatibility in 3rd party tools? Regards, Bernhard