From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751628Ab2I3TnH (ORCPT ); Sun, 30 Sep 2012 15:43:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54855 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526Ab2I3TnE (ORCPT ); Sun, 30 Sep 2012 15:43:04 -0400 Date: Sun, 30 Sep 2012 21:44:38 +0200 From: Oleg Nesterov To: Ingo Molnar , Peter Zijlstra , Srikar Dronamraju Cc: Ananth N Mavinakayanahalli , Anton Arapov , Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] uprobes: register/unregister bugfixes Message-ID: <20120930194438.GA11222@redhat.com> References: <20120930194119.GA11278@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120930194119.GA11278@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Forgot to mention, This is on top of "[PATCH 0/3] uprobes: mprotect fixes" series, which is still waiting for review... On 09/30, Oleg Nesterov wrote: > > Hello. > > Misc bugfixes, mostly register/unregister related. > > Note: 4/7 and especially 6/7 are the really ugly (but hopefully > temporary) hacks. We already discussed this, we should inspect > the original insn in uprobe_register(). But this is not easy, and > we need something simple to fix (some of) the bugs right now. > > Even 7/7 is ugly. Imho UPROBE_SKIP_SSTEP should die as well but > this is another story. > > Oleg. > > arch/x86/kernel/uprobes.c | 16 +------ > include/linux/uprobes.h | 10 ---- > kernel/events/uprobes.c | 107 +++++++++++++++++++++++++++++++------------- > 3 files changed, 77 insertions(+), 56 deletions(-)