From: Guenter Roeck <linux@roeck-us.net>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: lm-sensors@lm-sensors.org,
Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>,
Jean Delvare <khali@linux-fr.org>,
linux-kernel@vger.kernel.org, Steve Hardy <shardy@redhat.com>
Subject: Re: [PATCH v2 2/2] hwmon: (ads7828) add support for ADS7830
Date: Mon, 1 Oct 2012 21:35:00 -0700 [thread overview]
Message-ID: <20121002043500.GA3247@roeck-us.net> (raw)
In-Reply-To: <1349148501.5876.22.camel@trivette>
On Mon, Oct 01, 2012 at 11:28:21PM -0400, Vivien Didelot wrote:
> Hi Guenter,
>
Hi Vivien,
[ ... ]
> > > + } else {
> > > + dev_dbg(&client->dev, "doesn't look like an "
> > > + "ADS7828 compatible device\n");
> >
> > WARNING: quoted string split across lines
> > #190: FILE: drivers/hwmon/ads7828.c:196:
> > + dev_dbg(&client->dev, "doesn't look like an "
> > + "ADS7828 compatible device\n");
> Hum ok, so the reason for that is that it breaks the ability to grep a
> string... Makes sense.
> >
> > Better:
> > dev_dbg(&client->dev,
> > "doesn't look like an ADS7828 compatible device\n");
> This exceeds 80 chars, but I'll find a shorter message.
That is ok nowadays if it is due to a quoted string.
Guenter
next prev parent reply other threads:[~2012-10-02 4:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 23:16 [PATCH v2 1/2] hwmon: (ads7828) driver cleanup Vivien Didelot
2012-10-01 23:16 ` [PATCH v2 2/2] hwmon: (ads7828) add support for ADS7830 Vivien Didelot
2012-10-02 1:20 ` Guenter Roeck
2012-10-02 3:28 ` Vivien Didelot
2012-10-02 4:35 ` Guenter Roeck [this message]
2012-10-02 1:07 ` [PATCH v2 1/2] hwmon: (ads7828) driver cleanup Guenter Roeck
2012-10-02 2:16 ` Vivien Didelot
2012-10-02 2:55 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121002043500.GA3247@roeck-us.net \
--to=linux@roeck-us.net \
--cc=guillaume.roguez@savoirfairelinux.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=shardy@redhat.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox