From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Valdis.Kletnieks@vt.edu,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: silence GCC warning
Date: Wed, 3 Oct 2012 12:06:47 +0100 [thread overview]
Message-ID: <20121003110646.GD4360@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1349249016.1414.55.camel@x61.thuisdomein>
On Wed, Oct 03, 2012 at 09:23:36AM +0200, Paul Bolle wrote:
> On Tue, 2012-10-02 at 20:11 -0400, Valdis.Kletnieks@vt.edu wrote:
> > On Mon, 01 Oct 2012 11:03:21 +0100, Mark Brown said:
> > > > That implies that 'ret' will be set in the if-branch. ('val_count' could
> > > > be zero if 'val_len' is, for example, zero. That would be useless input,
> > > > however.)
> > But gcc doesn't know what "useless input" means, semantically.
> Correct. When this function is compiled gcc has to take into account
> that 'val_len' will be called with useless input, like zero.
> By the way, GCC doesn't warn if I add an early check whether 'val_count'
> is non-zero:
That's a much more useful fix, bodging things by just forcing things to
be assigned (especially with the way you were converting the immediate
returns) is generally terrible - it's just shutting up the errors
without actually fixing any issues that really exist and means that if
the compiler ever notices actual issues we won't see them.
next prev parent reply other threads:[~2012-10-03 11:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 10:15 [PATCH] regmap: silence GCC warning Paul Bolle
2012-10-01 10:03 ` Mark Brown
2012-10-01 10:16 ` Paul Bolle
2012-10-01 10:19 ` Mark Brown
2012-10-01 10:32 ` Paul Bolle
2012-10-01 11:39 ` Mark Brown
2012-10-01 19:08 ` Paul Bolle
2012-10-01 19:11 ` Mark Brown
2012-10-03 0:11 ` Valdis.Kletnieks
2012-10-03 7:23 ` Paul Bolle
2012-10-03 11:06 ` Mark Brown [this message]
2012-10-05 22:20 ` Valdis.Kletnieks
2012-10-06 8:53 ` Mark Brown
2012-10-06 9:57 ` Paul Bolle
2012-10-08 1:14 ` Mark Brown
2012-10-08 20:06 ` [PATCH v2] " Paul Bolle
2012-10-12 6:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121003110646.GD4360@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox