From: "Henrik Rydberg" <rydberg@euromail.se>
To: Alexandra Chin <alexandra.chin@tw.synaptics.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Input <linux-input@vger.kernel.org>,
Linus Walleij <linus.walleij@stericsson.com>,
Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com>,
Mahesh Srinivasan <msrinivasan@synaptics.com>,
Alex Chang <alex.chang@tw.synaptics.com>,
Scott Lin <scott.lin@tw.synaptics.com>,
Christopher Heiny <Cheiny@synaptics.com>
Subject: Re: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices
Date: Wed, 3 Oct 2012 20:01:21 +0200 [thread overview]
Message-ID: <20121003180121.GA4198@polaris.bitmath.org> (raw)
In-Reply-To: <CC51EC7B5B7F984AA566DC102237848896F590C0@hkdcw-mail1.synaptics-inc.local>
Hi Alexandra,
> Hi Henrik/Dmitry,
>
> We are working on a product specific driver for Synaptics DS4 I2C touchscreen
> devices. It was submitted on Sept. 16, 2012, but has not been reviewed.
> (http://lkml.org/lkml/2012/9/16/24).
> We found several warnings after running script/checkpatch.pl, therefore
> an updated patch is attached.
>
> As Chris says in https://lkml.org/lkml/2012/9/19/505, this driver will enable
> us to support all our customers effectively and provide our customers with
> the best flexibility possible.
> Please help review attached patch, and we really appreciate your feedback :-)
It seems this driver is already present in staging. Comments and
formatting have been improved in the staging version, but that aside,
the two versions look very similar. Why don't you submit fixes to
that driver instead?
On a general note, both versions of the driver use MT-A. Please
convert to MT-B, using the in-kernel tracking if necessary.
Thanks.
Henrik
next prev parent reply other threads:[~2012-10-03 17:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 3:30 [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices Alexandra Chin
2012-10-03 18:01 ` Henrik Rydberg [this message]
2012-10-04 5:52 ` Alexandra Chin
2012-10-04 6:51 ` Dmitry Torokhov
2012-10-05 9:44 ` Alexandra Chin
2012-10-31 9:17 ` [PATCH] staging: ste_rmi4: Convert to Type-B support Alexandra Chin
2012-10-31 18:43 ` Henrik Rydberg
2012-11-01 3:14 ` Alexandra Chin
-- strict thread matches above, loose matches on Subject: below --
2012-10-02 7:50 [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices Alexandra Chin
2012-09-16 9:56 Alexandra Chin
2012-09-16 22:33 ` Linus Walleij
2012-09-19 21:57 ` Christopher Heiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121003180121.GA4198@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=Cheiny@synaptics.com \
--cc=alex.chang@tw.synaptics.com \
--cc=alexandra.chin@tw.synaptics.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msrinivasan@synaptics.com \
--cc=naveen.gaddipati@stericsson.com \
--cc=scott.lin@tw.synaptics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).