From: Andi Kleen <andi@firstfloor.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
richard -rw- weinberger <richard.weinberger@gmail.com>,
"Markus F.X.J. Oberhumer" <markus@oberhumer.com>,
linux-kernel@vger.kernel.org, chris.mason@fusionio.com,
linux-btrfs@vger.kernel.org, Nitin Gupta <ngupta@vflare.org>,
Johannes Stezenbach <js@sig21.net>
Subject: Re: [GIT PULL v2] Update LZO compression
Date: Thu, 4 Oct 2012 03:51:22 +0200 [thread overview]
Message-ID: <20121004015122.GK16230@one.firstfloor.org> (raw)
In-Reply-To: <20121003143200.69a50aad.akpm@linux-foundation.org>
> > > - Post the entire patch series to lkml for review (I'd like a cc please)
> >
> > Already happened, multiple people reviewed and tested.
>
> um, I would not consider "Looks ok to me from a quick look." and "I
> couldn't tell from the github view, but I assume you follow standard
> coding style." to indicate a rigorous code review!
Let's put it like this. LZO is mature widely used production software and
Markus wrote and maintains it. Essentially this is a release from him.
The main problem before with using his version directly was that it did
not follow Linux coding standards, but that seems to be fixed now. It's
also relatively simple and at least I didn't spot anything bad when I looked.
It was runtime tested by several people on different architectures.
If it was fuzzed so we can assume reasonably good security.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2012-10-04 1:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 15:21 [GIT PULL v2] Update LZO compression Markus F.X.J. Oberhumer
2012-08-22 10:34 ` Johannes Stezenbach
2012-10-03 10:34 ` Markus F.X.J. Oberhumer
2012-10-03 10:48 ` richard -rw- weinberger
2012-10-03 21:01 ` Andrew Morton
2012-10-03 21:19 ` Andi Kleen
2012-10-03 21:32 ` Andrew Morton
2012-10-04 1:51 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121004015122.GK16230@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@fusionio.com \
--cc=js@sig21.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@oberhumer.com \
--cc=ngupta@vflare.org \
--cc=richard.weinberger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).