From: Gleb Natapov <gleb@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com,
x86@vger.kernel.org, eranian@google.com, jolsa@redhat.com,
a.p.zijlstra@chello.nl, Andi Kleen <ak@linux.intel.com>,
avi@redhat.com
Subject: Re: [06/31] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation
Date: Thu, 4 Oct 2012 11:10:59 +0200 [thread overview]
Message-ID: <20121004091059.GY23096@redhat.com> (raw)
In-Reply-To: <1349221731-15665-7-git-send-email-andi@firstfloor.org>
On Tue, Oct 02, 2012 at 11:48:26PM -0000, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> This is not arch perfmon, but older CPUs will just ignore it. This makes
> it possible to do at least some TSX measurements from a KVM guest
>
> Cc: avi@redhat.com
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> ---
> arch/x86/kvm/pmu.c | 13 ++++++++++---
> 1 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c
> index 9b7ec11..f72a409 100644
> --- a/arch/x86/kvm/pmu.c
> +++ b/arch/x86/kvm/pmu.c
> @@ -160,7 +160,7 @@ static void stop_counter(struct kvm_pmc *pmc)
>
> static void reprogram_counter(struct kvm_pmc *pmc, u32 type,
> unsigned config, bool exclude_user, bool exclude_kernel,
> - bool intr)
> + bool intr, bool intx, bool intx_cp)
> {
> struct perf_event *event;
> struct perf_event_attr attr = {
> @@ -173,6 +173,11 @@ static void reprogram_counter(struct kvm_pmc *pmc, u32 type,
> .exclude_kernel = exclude_kernel,
> .config = config,
> };
> + /* Will be ignored on CPUs that don't support this. */
> + if (intx)
> + attr.config |= HSW_INTX;
> + if (intx_cp)
> + attr.config |= HSW_INTX_CHECKPOINTED;
>
> attr.sample_period = (-pmc->counter) & pmc_bitmask(pmc);
>
> @@ -239,7 +244,9 @@ static void reprogram_gp_counter(struct kvm_pmc *pmc, u64 eventsel)
> reprogram_counter(pmc, type, config,
> !(eventsel & ARCH_PERFMON_EVENTSEL_USR),
> !(eventsel & ARCH_PERFMON_EVENTSEL_OS),
> - eventsel & ARCH_PERFMON_EVENTSEL_INT);
> + eventsel & ARCH_PERFMON_EVENTSEL_INT,
> + !!(eventsel & HSW_INTX),
> + !!(eventsel & HSW_INTX_CHECKPOINTED));
Before reprogram_gp_counter() is called from kvm_pmu_set_msr() eventsel
is checked for reserved bits. Both HSW_INTX and HSW_INTX_CHECKPOINTED
are marked as reserved currently. Reserved bit mask should depend on
cpuid bits provided to a guest.
> }
>
> static void reprogram_fixed_counter(struct kvm_pmc *pmc, u8 en_pmi, int idx)
> @@ -256,7 +263,7 @@ static void reprogram_fixed_counter(struct kvm_pmc *pmc, u8 en_pmi, int idx)
> arch_events[fixed_pmc_events[idx]].event_type,
> !(en & 0x2), /* exclude user */
> !(en & 0x1), /* exclude kernel */
> - pmi);
> + pmi, false, false);
> }
>
> static inline u8 fixed_en_pmi(u64 ctrl, int idx)
--
Gleb.
next prev parent reply other threads:[~2012-10-04 9:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 23:48 perf PMU support for Haswell v2 Andi Kleen
2012-10-02 23:48 ` [PATCH 01/31] perf, x86: Add PEBSv2 record support Andi Kleen
2012-10-02 23:48 ` [PATCH 02/31] perf, x86: Basic Haswell PMU support v2 Andi Kleen
2012-10-02 23:48 ` [PATCH 03/31] perf, x86: Basic Haswell PEBS support Andi Kleen
2012-10-02 23:48 ` [PATCH 04/31] perf, x86: Support the TSX intx/intx_cp qualifiers Andi Kleen
2012-10-02 23:48 ` [PATCH 05/31] perf, x86: Report PEBS event in a raw format Andi Kleen
2012-10-02 23:48 ` [PATCH 06/31] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation Andi Kleen
2012-10-03 10:27 ` Avi Kivity
2012-10-03 12:11 ` Andi Kleen
2012-10-03 12:54 ` Avi Kivity
2012-10-04 9:10 ` Gleb Natapov [this message]
2012-10-02 23:48 ` [PATCH 07/31] perf, x86: Support PERF_SAMPLE_ADDR on Haswell Andi Kleen
2012-10-02 23:48 ` [PATCH 08/31] perf, x86: Support Haswell v4 LBR format Andi Kleen
2012-10-02 23:48 ` [PATCH 09/31] perf, x86: Disable LBR recording for unknown LBR_FMT Andi Kleen
2012-10-02 23:48 ` [PATCH 10/31] perf, x86: Support LBR filtering by INTX/NOTX/ABORT Andi Kleen
2012-10-02 23:48 ` [PATCH 11/31] perf, tools: Add abort,notx,intx branch filter options to perf report -j Andi Kleen
2012-10-02 23:48 ` [PATCH 12/31] perf, tools: Support sorting by intx, abort branch flags Andi Kleen
2012-10-02 23:48 ` [PATCH 13/31] perf, x86: Support full width counting on Haswell Andi Kleen
2012-10-02 23:48 ` [PATCH 14/31] perf, x86: Avoid checkpointed counters causing excessive TSX aborts Andi Kleen
2012-10-02 23:48 ` [PATCH 15/31] perf, core: Add a concept of a weightened sample Andi Kleen
2012-10-02 23:48 ` [PATCH 16/31] perf, x86: Support weight samples for PEBS Andi Kleen
2012-10-02 23:48 ` [PATCH 17/31] perf, tools: Add support for weight Andi Kleen
2012-10-02 23:48 ` [PATCH 18/31] perf, tools: Handle XBEGIN like a jump Andi Kleen
2012-10-02 23:48 ` [PATCH 19/31] perf, x86: Support for printing PMU state on spurious PMIs v2 Andi Kleen
2012-10-02 23:48 ` [PATCH 20/31] perf, core: Add generic transaction flags Andi Kleen
2012-10-02 23:48 ` [PATCH 21/31] perf, x86: Add Haswell specific transaction flag reporting Andi Kleen
2012-10-02 23:48 ` [PATCH 22/31] perf, tools: Add support for record transaction flags Andi Kleen
2012-10-02 23:48 ` [PATCH 23/31] perf, tools: Point --sort documentation to --help Andi Kleen
2012-10-02 23:48 ` [PATCH 24/31] perf, tools: Add browser support for transaction flags Andi Kleen
2012-10-02 23:48 ` [PATCH 25/31] perf, tools: Move parse_events error printing to parse_events_options Andi Kleen
2012-10-02 23:48 ` [PATCH 26/31] perf, tools: Support events with - in the name Andi Kleen
2012-10-02 23:48 ` [PATCH 27/31] perf, x86: Report the arch perfmon events in sysfs Andi Kleen
2012-10-02 23:48 ` [PATCH 28/31] tools, perf: Add a precise event qualifier Andi Kleen
2012-10-02 23:48 ` [PATCH 29/31] perf, x86: Add Haswell TSX event aliases Andi Kleen
2012-10-02 23:48 ` [PATCH 30/31] perf, tools: Add perf stat --transaction Andi Kleen
2012-10-02 23:48 ` [PATCH 31/31] perf, x86: Add a Haswell precise instructions event Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121004091059.GY23096@redhat.com \
--to=gleb@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).