* virtio build breakage.
@ 2012-10-04 22:59 Dave Jones
2012-10-06 7:34 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2012-10-04 22:59 UTC (permalink / raw)
To: Rusty Russell; +Cc: Linux Kernel
After linking, I see this..
ERROR: "virtqueue_kick" [net/9p/9pnet_virtio.ko] undefined!
ERROR: "virtqueue_get_buf" [net/9p/9pnet_virtio.ko] undefined!
ERROR: "virtqueue_add_buf" [net/9p/9pnet_virtio.ko] undefined!
ERROR: "virtqueue_notify" [drivers/scsi/virtio_scsi.ko] undefined!
ERROR: "virtqueue_kick_prepare" [drivers/scsi/virtio_scsi.ko] undefined!
ERROR: "virtqueue_kick" [drivers/scsi/virtio_scsi.ko] undefined!
ERROR: "virtqueue_add_buf" [drivers/scsi/virtio_scsi.ko] undefined!
ERROR: "virtqueue_enable_cb" [drivers/scsi/virtio_scsi.ko] undefined!
ERROR: "virtqueue_get_buf" [drivers/scsi/virtio_scsi.ko] undefined!
ERROR: "virtqueue_disable_cb" [drivers/scsi/virtio_scsi.ko] undefined!
ERROR: "vring_del_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
ERROR: "vring_new_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
ERROR: "vring_interrupt" [drivers/remoteproc/remoteproc.ko] undefined!
ERROR: "vring_transport_features" [drivers/remoteproc/remoteproc.ko] undefined!
ERROR: "virtqueue_enable_cb_delayed" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_enable_cb" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_kick" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_add_buf" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_disable_cb" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_get_buf" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_detach_unused_buf" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_get_vring_size" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_disable_cb" [drivers/char/virtio_console.ko] undefined!
ERROR: "virtqueue_detach_unused_buf" [drivers/char/virtio_console.ko] undefined!
ERROR: "virtqueue_kick" [drivers/char/virtio_console.ko] undefined!
ERROR: "virtqueue_add_buf" [drivers/char/virtio_console.ko] undefined!
ERROR: "virtqueue_get_buf" [drivers/char/virtio_console.ko] undefined!
ERROR: "virtqueue_kick" [drivers/char/hw_random/virtio-rng.ko] undefined!
ERROR: "virtqueue_add_buf" [drivers/char/hw_random/virtio-rng.ko] undefined!
ERROR: "virtqueue_get_buf" [drivers/char/hw_random/virtio-rng.ko] undefined!
ERROR: "virtqueue_kick" [drivers/block/virtio_blk.ko] undefined!
ERROR: "virtqueue_add_buf" [drivers/block/virtio_blk.ko] undefined!
ERROR: "virtqueue_get_buf" [drivers/block/virtio_blk.ko] undefined!
config is at http://fpaste.org/svfL/raw
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: virtio build breakage.
2012-10-04 22:59 virtio build breakage Dave Jones
@ 2012-10-06 7:34 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2012-10-06 7:34 UTC (permalink / raw)
To: Dave Jones; +Cc: Linux Kernel
Dave Jones <davej@redhat.com> writes:
> After linking, I see this..
>
> ERROR: "virtqueue_kick" [net/9p/9pnet_virtio.ko] undefined!
> ERROR: "virtqueue_get_buf" [net/9p/9pnet_virtio.ko] undefined!
Cool!
Someone else spotted this recently, and the fix is in my recent pull
request to Linus:
commit 04679f34c141a0591e525d392929efc249440a7c
Author: Michael S. Tsirkin <mst@redhat.com>
Date: Fri Sep 28 15:05:14 2012 +0930
virtio-balloon: dependency fix
Devices should depend on virtio, not select it. It's supposed to be
selected by the particular driver, e.g. VIRTIO_PCI.
Make balloon depend on VIRTIO and EXPERIMENTAL
(to match description).
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index f38b17a..271be80 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -27,8 +27,7 @@ config VIRTIO_PCI
config VIRTIO_BALLOON
tristate "Virtio balloon driver (EXPERIMENTAL)"
- select VIRTIO
- select VIRTIO_RING
+ depends on EXPERIMENTAL && VIRTIO
---help---
This driver supports increasing and decreasing the amount
of memory within a KVM guest.
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-06 7:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-04 22:59 virtio build breakage Dave Jones
2012-10-06 7:34 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).